From owner-cvs-all@FreeBSD.ORG Thu Feb 14 02:02:03 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 776DE16A419; Thu, 14 Feb 2008 02:02:03 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 56D0F13C448; Thu, 14 Feb 2008 02:02:03 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 337351A4D95; Wed, 13 Feb 2008 18:02:03 -0800 (PST) Date: Wed, 13 Feb 2008 18:02:03 -0800 From: Alfred Perlstein To: Robert Watson Message-ID: <20080214020203.GP99258@elvis.mu.org> References: <200802131545.m1DFjCq0092390@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802131545.m1DFjCq0092390@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/coda cnode.h coda_subr.c coda_vnops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2008 02:02:03 -0000 * Robert Watson [080213 07:45] wrote: > rwatson 2008-02-13 15:45:12 UTC > > FreeBSD src repository > > Modified files: > sys/fs/coda cnode.h coda_subr.c coda_vnops.c > Log: ... > Since the Coda module is agressive about not keeping around > unopened cnodes, the utility of the cache is somewhat limited for > files, but works will for directories. We should make Coda less > agressive about GCing cnodes in VOP_INACTIVE() in order to improve > the effectiveness of in-kernel caching of attributes and access > rights. Move the GC to the VOP_RECLAIM VOP and you'll get what you want. -Alfred