From owner-svn-src-stable-8@FreeBSD.ORG Sun Nov 21 11:30:43 2010 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93C50106564A; Sun, 21 Nov 2010 11:30:43 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from fep21.mx.upcmail.net (fep21.mx.upcmail.net [62.179.121.41]) by mx1.freebsd.org (Postfix) with ESMTP id B98398FC23; Sun, 21 Nov 2010 11:30:41 +0000 (UTC) Received: from edge01.upcmail.net ([192.168.13.236]) by viefep19-int.chello.at (InterMail vM.8.01.02.02 201-2260-120-106-20100312) with ESMTP id <20101121111217.FOFX1944.viefep19-int.chello.at@edge01.upcmail.net>; Sun, 21 Nov 2010 12:12:17 +0100 Received: from mole.fafoe.narf.at ([213.47.85.26]) by edge01.upcmail.net with edge id ZnC81f02R0a5KZh01nCFfb; Sun, 21 Nov 2010 12:12:17 +0100 X-SourceIP: 213.47.85.26 Received: by mole.fafoe.narf.at (Postfix, from userid 1001) id 5FF4E6D444; Sun, 21 Nov 2010 12:12:08 +0100 (CET) Date: Sun, 21 Nov 2010 12:12:08 +0100 From: Stefan Farfeleder To: Bernhard Schmidt Message-ID: <20101121111207.GA1750@mole.fafoe.narf.at> References: <201011211049.oALAnfH9052005@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201011211049.oALAnfH9052005@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Cloudmark-Analysis: v=1.1 cv=Nww7yNiXF4C1XGF+VcigPkOcTpD8wJaI1KQuZlH5eEk= c=1 sm=0 a=yF0Mc-4E0fAA:10 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=xQCMCsRg1ZaQJfjp9agA:9 a=KoVW27Ht2-l2dpiXFOoA:7 a=a_StgVpAFM1meE1c78ByaU4kHLwA:4 a=CjuIK1q_8ugA:10 a=BxYSXnMOQfUdJYfX:21 a=Luw9Xme5PORhV0gY:21 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r215612 - stable/8/sys/net80211 X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Nov 2010 11:30:43 -0000 On Sun, Nov 21, 2010 at 10:49:41AM +0000, Bernhard Schmidt wrote: > Author: bschmidt > Date: Sun Nov 21 10:49:40 2010 > New Revision: 215612 > URL: http://svn.freebsd.org/changeset/base/215612 > > Log: > Compare the address of the array, not the array. > > Committed by: rpaulo > Found with: Coverity Prevent(tm) > CID: 3690 This doesn't make sense to me. How can the address of the array member be null? Also comparing the array and comparing its address has the same effect as the array is converted to the pointer anyway in the context of the comparison. Stefan > Modified: > stable/8/sys/net80211/ieee80211_scan_sta.c > Directory Properties: > stable/8/sys/ (props changed) > stable/8/sys/amd64/include/xen/ (props changed) > stable/8/sys/cddl/contrib/opensolaris/ (props changed) > stable/8/sys/contrib/dev/acpica/ (props changed) > stable/8/sys/contrib/pf/ (props changed) > stable/8/sys/dev/xen/xenpci/ (props changed) > > Modified: stable/8/sys/net80211/ieee80211_scan_sta.c > ============================================================================== > --- stable/8/sys/net80211/ieee80211_scan_sta.c Sun Nov 21 10:45:10 2010 (r215611) > +++ stable/8/sys/net80211/ieee80211_scan_sta.c Sun Nov 21 10:49:40 2010 (r215612) > @@ -1013,7 +1013,7 @@ match_bss(struct ieee80211vap *vap, > */ > if (se->se_capinfo & (IEEE80211_CAPINFO_IBSS|IEEE80211_CAPINFO_ESS)) > fail |= MATCH_CAPINFO; > - else if (se->se_meshid == NULL) > + else if (&se->se_meshid == NULL) > fail |= MATCH_MESH_NOID; > else if (ms->ms_idlen != 0 && > match_id(se->se_meshid, ms->ms_id, ms->ms_idlen)) >