From owner-freebsd-current@FreeBSD.ORG Wed Apr 8 17:16:53 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E89110656D7 for ; Wed, 8 Apr 2009 17:16:53 +0000 (UTC) (envelope-from kevinxlinuz@163.com) Received: from m12-11.163.com (m12-11.163.com [220.181.12.11]) by mx1.freebsd.org (Postfix) with SMTP id CDEEC8FC1A for ; Wed, 8 Apr 2009 17:16:51 +0000 (UTC) (envelope-from kevinxlinuz@163.com) Received: from [127.0.0.1] (unknown [60.191.86.3]) by smtp7 (Coremail) with SMTP id C8CowLALeX_129xJP_ghQQ--.12184S2; Thu, 09 Apr 2009 01:16:38 +0800 (CST) Message-ID: <49DCDBF6.5040700@163.com> Date: Thu, 09 Apr 2009 01:16:38 +0800 From: kevin User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Norikatsu Shigemura References: <49BD117B.2080706@163.com> <20090331100328.H46640@rust.salford.ac.uk> <20090401044011.GA51164@plebeian.afflictions.org> <200904010846.55770.hselasky@c2i.net> <20090401121704.GA92522@plebeian.afflictions.org> <20090401234315.GA11125@plebeian.afflictions.org> <20090405015627.GB47968@plebeian.afflictions.org> <012d01c9b706$ccace720$6606b560$@Sparrevohn@btinternet.com> <20090409003108.fe768d54.nork@FreeBSD.org> In-Reply-To: <20090409003108.fe768d54.nork@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: C8CowLALeX_129xJP_ghQQ--.12184S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7CrW8tF48JF1kZFy5Kw4rKrg_yoW8AF4kpr W3Grn2yF1UurWjyr18Xr48A3Wj9a18Jr43Gr4fGw1IkFy5CFn3trySgr18WFyDCrZxCrW8 Xa10qr1UAr95AwUanT9S1TB71UUUUUUv73VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UU U5o7k042IE42xK82IY6r43WwAYjxAI6xAIw28IcVAK0I8IjxAxM7k042IE4IxYO2xFxVAq jxCEw4Av424lb7Iv0xC_Ar1lb4IE77IF4wAFF20E14v26r1j6r4UM7C26xCjj4IEI4klw4 CSwwAFxVCaYxvI4VCIwcAKzIAtM7CIcVAFz4kK6r1j6r18M28EF7xvwVC0I7IYx2IY67AK xVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIE14 v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAawVAYYI1S6c8GOVWUur45 Jryln4vEF7Iv6F18KVAqrcv_GVWUtr1rJF1ln4vEF7Iv6F18KVAqrcv_XVWUtr1rJF1lnx 0Ec2IEnICE548m6r1DJrWUZwAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAF wI0_Jr0_Jr4lYx0Ex4A2jsIE14v26F4j6r4UJwACjcxG0xvEwIxGrwAC62BYpTIE1TZKA3 svLVAKvSnIqfZI6r4l7I0Y64k_MxkIecxEwVAFwVW8MxkI7II2jI8vz4v_Cr0_Zr1l42xK 82IYc2Ij64vIr41l4x8a6c8ajcxJMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr4 UvcSsGvfC2KfnxnUUI43ZEXa7IUjPxhPUUUUU== X-CM-SenderInfo: pnhyx0x0ol03r26rljoofrz/ Cc: Thomas Sparrevohn , freebsd-current@FreeBSD.org, 'Damian Gerow' , jhb@FreeBSD.org Subject: Re: ZFS checksum errors on USB attach (Was: ZFS data error without reasons) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2009 17:16:54 -0000 Norikatsu Shigemura wrote: > Hi jhb! > > I got ZFS checksum error issue, too. So I found a way of fixing > this issue. Please back out following change. > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_dir.c > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > revision 1.5 > date: 2009/03/18 16:19:44; author: jhb; state: Exp; lines: +2 -0 > SVN rev 189967 on 2009-03-18 16:19:44Z by jhb > > The zfs_get_xattrdir() function is used to find the extended attribute > directory for a znode. When the directory already exists, it returns a > referenced but unlocked vnode. When a directory does not yet exist, it > calls zfs_make_xattrdir() to create a new one. zfs_make_xattrdir() returns > the vnode both referenced and and locked and zfs_get_xattrdir() was leaking > this vnode lock to its callers. Fix this by dropping the vnode lock if > zfs_make_xattrdir() successfully creates a new extended attribute > directory. > > Reviewed by: pjd > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > > [Validation] > 1. I got ZFS checksum error issue > 2. Backup > 3. Restructure ZPool > 4. Restore (But ZFS checksum error) > 5. Restructure ZPool with kern.smp.disabled=1 > (Almost good, but...) > 6. Restore > 7. Backout zfs_dir#1.5 > 8. Good works for me > > I tested many backup&restore:-). > > On Mon, 6 Apr 2009 23:26:57 +0100 > "Thomas Sparrevohn" wrote: > >> Just a me too - Here - I just seen significant corruption of a newly >> restored pool - the system had been running a portupgrade - I am getting >> worried - but the disks shows no errors - neither from the ATA subsystem nor >> from smartctl or some vendor testing tools I have >> It just fix some case.Have you tried to import a zpool on a usb hard disk? Thanks, kevin