From owner-svn-src-all@FreeBSD.ORG Thu Sep 5 14:32:16 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8BE32E18; Thu, 5 Sep 2013 14:32:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 61D1B2392; Thu, 5 Sep 2013 14:32:16 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9C31EB97A; Thu, 5 Sep 2013 10:32:12 -0400 (EDT) From: John Baldwin To: Konstantin Belousov Subject: Re: svn commit: r255192 - in head: contrib/binutils/gas/config contrib/binutils/opcodes sys/amd64/amd64 Date: Thu, 5 Sep 2013 08:27:18 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p28; KDE/4.5.5; amd64; ; ) References: <201309032121.r83LLlI5026519@svn.freebsd.org> <201309040756.45464.jhb@freebsd.org> <20130905004430.GM41229@kib.kiev.ua> In-Reply-To: <20130905004430.GM41229@kib.kiev.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201309050827.18567.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 05 Sep 2013 10:32:12 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 14:32:16 -0000 On Wednesday, September 04, 2013 8:44:30 pm Konstantin Belousov wrote: > On Wed, Sep 04, 2013 at 07:56:45AM -0400, John Baldwin wrote: > > On Wednesday, September 04, 2013 12:25:35 am Konstantin Belousov wrote: > > > On Tue, Sep 03, 2013 at 09:21:47PM +0000, John Baldwin wrote: > > > > Author: jhb > > > > Date: Tue Sep 3 21:21:47 2013 > > > > New Revision: 255192 > > > > URL: http://svnweb.freebsd.org/changeset/base/255192 > > > > > > > > Log: > > > > Add support for the 'invpcid' instruction to binutils and DDB's > > > > disassembler on amd64. > > > > > > > > MFC after: 1 month > > > > > > Nice, thank you. > > > > > > Do you agree with me that it is premature to start using the mnemonics > > > in the kernel source until the changes are merged into stable/9 at least ? > > > > That is fine. Can you test that using them directly works fine with GCC? > > I know clang already supported this instruction. > > Hmm, tried make buildkernel CC=gcc for the world (and builworld area) > built after your commit. I get > > gcc -c -x assembler-with-cpp -DLOCORE -O2 -frename-registers -pipe -fno-strict-a > liasing -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototype > s -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-point > er-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option > -nostdinc -I. -I/usr/home/kostik/work/build/bsd/DEV/src/sys -I/usr/home/kostik/ > work/build/bsd/DEV/src/sys/contrib/altq -I/usr/home/kostik/work/build/bsd/DEV/sr > c/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global. > h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-f > unction-growth=1000 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcmod > el=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind > -tables -ffreestanding -fstack-protector -Werror /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/exception.S > /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S: Assembler messages: > /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S:224: Error: no such instruction: `invpcid (%rdx),%rax' > /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S:312: Error: no such instruction: `invpcid (%rdx),%rax' > /usr/home/kostik/work/build/bsd/DEV/src/sys/amd64/amd64/apic_vector.S:409: Error: no such instruction: `invpcid (%rdx),%rax' > *** Error code 1 Hmm, I have no idea why this failed. :( It should definitely be using the new as after a buildworld. -- John Baldwin