Date: Thu, 30 Dec 2010 13:32:35 GMT From: Eitan Adler <lists@eitanadler.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/153547: [patch] remove NO_SIZE from the ports system Message-ID: <201012301332.oBUDWZtn065584@red.freebsd.org> Resent-Message-ID: <201012301340.oBUDeDDD019992@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 153547 >Category: ports >Synopsis: [patch] remove NO_SIZE from the ports system >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Dec 30 13:40:13 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Eitan Adler >Release: >Organization: >Environment: >Description: As explained in ports/153544 there are currently only 4 ports marked with NO_SIZE and of them only 1 doesn't actually report a size. I propose that there is no real reason to have a NO_SIZE option and it should be removed. >How-To-Repeat: >Fix: Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.666 diff -u -r1.666 bsd.port.mk --- bsd.port.mk 29 Dec 2010 07:14:56 -0000 1.666 +++ bsd.port.mk 30 Dec 2010 13:15:54 -0000 @@ -871,14 +871,6 @@ # change the owner and group of all files under ${WRKDIR} # to 0:0. Set this variable if you want to turn off this # feature. -# -# For makesum: -# -# NO_SIZE - Don't record size data in distinfo, needed -# when the master site does not report file -# sizes, or when multiple valid versions of -# a distfile, having different sizes, exist. -# # For patch: # # EXTRA_PATCHES - Define this variable if you have patches not in @@ -4926,9 +4918,7 @@ $$alg_executable $$file >> ${DISTINFO_FILE}; \ fi; \ done; \ - if [ -z "${NO_SIZE}" ]; then \ - ${ECHO_CMD} "SIZE ($$file) = "`${LS} -ALln $$file | ${AWK} '{print $$5}'` >> ${DISTINFO_FILE}; \ - fi; \ + ${ECHO_CMD} "SIZE ($$file) = "`${LS} -ALln $$file | ${AWK} '{print $$5}'` >> ${DISTINFO_FILE}; \ done \ ) @for file in ${_IGNOREFILES}; do \ >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012301332.oBUDWZtn065584>