From owner-cvs-src@FreeBSD.ORG Thu May 1 00:20:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D629A37B401; Thu, 1 May 2003 00:20:27 -0700 (PDT) Received: from obsecurity.dyndns.org (adsl-67-115-75-172.dsl.lsan03.pacbell.net [67.115.75.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF3FD43FB1; Thu, 1 May 2003 00:20:26 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: from rot13.obsecurity.org (rot13.obsecurity.org [10.0.0.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 755A966B9B; Thu, 1 May 2003 00:20:26 -0700 (PDT) Received: by rot13.obsecurity.org (Postfix, from userid 1000) id 4BB261551; Thu, 1 May 2003 00:20:26 -0700 (PDT) Date: Thu, 1 May 2003 00:20:26 -0700 From: Kris Kennaway To: "Tim J. Robbins" Message-ID: <20030501072026.GA87518@rot13.obsecurity.org> References: <200305010642.h416g0sr018829@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <200305010642.h416g0sr018829@repoman.freebsd.org> User-Agent: Mutt/1.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2003 07:20:28 -0000 --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 30, 2003 at 11:42:00PM -0700, Tim J. Robbins wrote: > tjr 2003/04/30 23:42:00 PDT >=20 > FreeBSD src repository >=20 > Modified files: > sys/ufs/ffs ffs_vfsops.c=20 > Log: > Do not attempt to free NULL dinodes (i_din1 or i_din2) in ffs_ifree(). > These fields can be left as NULL if ffs_vget() allocates an inode but > fails before the dinode memory has been allocated. There are two cases > when this can occur: when we lose a race and another process has added > the inode to the hash, and when reading the inode off disk fails. > =20 > The bug was observed by Kris on one of the package-building machines. > See http://marc.theaimsgroup.com/?l=3Dfreebsd-current&m=3D1051727310134= 11&w=3D2 > In Kris's case, it was the bread() that failed because of a disk error. > =20 > The alternative to this patch is to ensure that ffs_vget() does not call > vput() when the inode that hasn't been properly initialised. Thanks! Kris --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+sMq6Wry0BWjoQKURAi3UAJ4szrRlT0NlcpCXkyaM0x2cCSl9xACeNPC0 OxHhibHylfWUH1d0D8pjjf0= =hrAX -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--