Date: Tue, 28 Mar 2023 11:56:10 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 3fd626858d82 - 2023Q1 - devel/rgbds: Fix build on 12.4 Message-ID: <CAFDf7U%2BbB9mgB-12FnQPkymHOOobEWHmaa6dSZh3E6GziWUBaA@mail.gmail.com> In-Reply-To: <ZCKgGxW1zfM3/MUT@FreeBSD.org> References: <202303130836.32D8a39n017978@gitrepo.freebsd.org> <6174ccaf-95ae-ae15-9ce2-a4c143154d06@pfeifer.com> <ZCKNZ3SUHJ382aLf@FreeBSD.org> <CAFDf7UKuDgxpxNP0-KSU5nYXxpNz11PczJ-7eY53orPzMwCRiQ@mail.gmail.com> <ZCKgGxW1zfM3/MUT@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000bcd12e05f7f3b5eb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello danfe! Thank you so much! I did test it without _POSIX_C_SOURCE but it failed at first because I did a mistake on reinplace cmd. It builds fine now. Also, OpenBSD is doing same to fix build until upstream fixes it: https://github.com/gbdev/rgbds/issues/1111 https://cgit.freebsd.org/ports/commit/?id=3De4d330bbdc82f346bc31f109ebff0d7= 1154362d0 Cheers, Alexey Dokuchaev <danfe@freebsd.org> escreveu no dia ter=C3=A7a, 28/03/2023= =C3=A0(s) 09:06: > On Tue, Mar 28, 2023 at 08:25:06AM +0100, Nuno Teixeira wrote: > > Hello, > > > > Upstream can't solve problem with clang >10 > > https://github.com/gbdev/rgbds/issues/1091 > > It builds fine for me with default compiler (12.4/13.1) and this target: > > post-patch: > # yank _POSIX_C_SOURCE because it breaks the build > ${REINPLACE_CMD} 's,-D_POSIX_C_SOURCE=3D200809L,,' ${WRKSRC}/Make= file > > Good code should not pass custom _POSIX_C_SOURCE anyway. :) > > ./danfe > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000bcd12e05f7f3b5eb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello danfe!</div><div><br></div><div>Thank you so mu= ch! I did test it without _POSIX_C_SOURCE but it failed at first because I = did a mistake on reinplace cmd.</div><div>It builds fine now.<br></div><div= ><br></div><div>Also, OpenBSD is doing same to fix build until upstream fix= es it:</div><div><a href=3D"https://github.com/gbdev/rgbds/issues/1111" tar= get=3D"_blank">https://github.com/gbdev/rgbds/issues/1111</a></div><div><br= ></div><div><a href=3D"https://cgit.freebsd.org/ports/commit/?id=3De4d330bb= dc82f346bc31f109ebff0d71154362d0">https://cgit.freebsd.org/ports/commit/?id= =3De4d330bbdc82f346bc31f109ebff0d71154362d0</a></div><div><br></div><div>Ch= eers,<br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class= =3D"gmail_attr">Alexey Dokuchaev <<a href=3D"mailto:danfe@freebsd.org" t= arget=3D"_blank">danfe@freebsd.org</a>> escreveu no dia ter=C3=A7a, 28/0= 3/2023 =C3=A0(s) 09:06:<br></div><blockquote class=3D"gmail_quote" style=3D= "margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-le= ft:1ex">On Tue, Mar 28, 2023 at 08:25:06AM +0100, Nuno Teixeira wrote:<br> > Hello,<br> > <br> > Upstream can't solve problem with clang >10<br> > <a href=3D"https://github.com/gbdev/rgbds/issues/1091" rel=3D"noreferr= er" target=3D"_blank">https://github.com/gbdev/rgbds/issues/1091</a><br>; <br> It builds fine for me with default compiler (12.4/13.1) and this target:<br= > <br> post-patch:<br> # yank _POSIX_C_SOURCE because it breaks the build<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${REINPLACE_CMD} 's,-D_POSIX_C_SOURCE=3D200= 809L,,' ${WRKSRC}/Makefile<br> <br> Good code should not pass custom _POSIX_C_SOURCE anyway. :)<br> <br> ./danfe<br> </blockquote></div><br clear=3D"all"><br><span>-- </span><br><div dir=3D"lt= r"><div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br= >FreeBSD Committer (ports)</span></div></div> --000000000000bcd12e05f7f3b5eb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2BbB9mgB-12FnQPkymHOOobEWHmaa6dSZh3E6GziWUBaA>