Date: Wed, 22 Aug 2012 10:10:45 +0100 From: Chris Rees <utisoft@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Pietro Cerutti <gahr@freebsd.org> Subject: Re: svn commit: r302141 - in head: audio/gnump3d audio/gnump3d/files audio/icecast2 audio/icecast2/files audio/ices0 audio/ices0/files audio/liquidsoap audio/liquidsoap/files audio/squeezeboxserver aud... Message-ID: <CADLo83--wgzNO_zASKAw40mSr4kUERijs1iEK_2_7zpAKnMY=Q@mail.gmail.com> In-Reply-To: <5033E858.7000400@FreeBSD.org> References: <201208052319.q75NJf5Q051549@svn.freebsd.org> <20120810120929.GR59600@gahrfit.gahr.ch> <CADLo83_vuv7f=pwKm1fVSckgrDfGA8m8DhA9Zp3nyG9G4zOX5w@mail.gmail.com> <5033E858.7000400@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 Aug 2012 21:00, "Doug Barton" <dougb@freebsd.org> wrote: > > On 8/10/2012 5:51 AM, Chris Rees wrote: > > On 10 August 2012 13:09, Pietro Cerutti <gahr@freebsd.org> wrote: > >> Mind to fix this please? > >> > >> http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/a.9.20120809134611/gnu-radius-1.6.1_4.log > >> > >> Thanks, > > > > Correct fix is at [1]. > > When I saw this message originally it never occurred to me that you > would go to all the trouble of producing a 1-line diff, put it up on a > web page, and post it to the mailing list .... and then not just punch > it in. > > Can you please explain why you would do this, and how this could > possibly be beneficial to the project? > It hadn't been approved by the maintainer. I would have linked to the commit message had I committed it. Perhaps it's not a big deal... but I always prefer to be the committer who fixed my pointyhats rather than having the appearance of having to be tidied up after. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83--wgzNO_zASKAw40mSr4kUERijs1iEK_2_7zpAKnMY=Q>