From owner-freebsd-ports  Thu Feb  8  2:28: 9 2001
Delivered-To: freebsd-ports@freebsd.org
Received: from blizzard.sabbo.net (ns.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id 14C0C37B401; Thu,  8 Feb 2001 02:27:42 -0800 (PST)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f18AR3g17997;
	Thu, 8 Feb 2001 12:27:03 +0200
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vic.sabbo.net (8.11.2/8.11.2) with ESMTP id f18AR5m10135;
	Thu, 8 Feb 2001 12:27:05 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3A827478.26A49757@FreeBSD.org>
Date: Thu, 08 Feb 2001 12:27:04 +0200
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.76 [en] (WinNT; U)
X-Accept-Language: uk,ru,en
MIME-Version: 1.0
To: Peter Pentchev <roam@orbitel.bg>
Cc: Jordan Hubbard <jkh@winston.osd.bsdi.com>, ports@FreeBSD.org,
	jkh@FreeBSD.org, Edwin Groothuis <mavetju@chello.nl>
Subject: Re: Request for comments [Fwd: bin/24695: [patch] pkg_info: prefix 
 search for a package]
References: <10197.981450491@winston.osd.bsdi.com> <3A7FC36A.1434D2CC@FreeBSD.org> <3A801D32.DE73F780@FreeBSD.org> <20010208122012.H21672@ringworld.oblivion.bg>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Peter Pentchev wrote:

> On Tue, Feb 06, 2001 at 05:50:10PM +0200, Maxim Sobolev wrote:
> > Maxim Sobolev wrote:
> >
> > Here it is. With this patch pkg_install treats any arguments as shell globs by
> > default and as regexs with -x, so for example the following is equivalent:
> > $ pkg_info foo\*
> > $ pkg_info -x ^foo.\*
> >
> > Please let me know what do you think about those patches.
>
> Finally got the time to look them over; they work great!
>
> Just one minor thing - look at the attached patch to completely get rid
> of the AllInstalled variable, and make pkg_info DTRT when called with
> no arguments (that was the first thing I tried, and it failed badly :)
>
> diff -urN pkg_install-orig/info/main.c pkg_install/info/main.c
> --- pkg_install-orig/info/main.c        Thu Feb  8 11:41:05 2001
> +++ pkg_install/info/main.c     Thu Feb  8 12:14:37 2001
> @@ -32,7 +32,6 @@
>
>  int    Flags           = 0;
>  match_t        MatchType       = MATCH_GLOB;
> -Boolean AllInstalled   = FALSE;
> [...]

OOPS, how I missed it??? :-/

Merged, thank you for your comment.

-Maxim





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message