From owner-svn-src-head@FreeBSD.ORG Wed Dec 21 20:42:50 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id D30E0106566B; Wed, 21 Dec 2011 20:42:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 1EF791529A0; Wed, 21 Dec 2011 20:42:50 +0000 (UTC) Message-ID: <4EF244CA.8040108@FreeBSD.org> Date: Wed, 21 Dec 2011 12:42:50 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Eitan Adler References: <201112212027.pBLKRfPK084637@svn.freebsd.org> <4EF243F2.7030000@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.3.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2011 20:42:50 -0000 On 12/21/2011 12:40 PM, Eitan Adler wrote: > On Wed, Dec 21, 2011 at 3:39 PM, Doug Barton wrote: >> A better way to write this commit log would be, "Remove null pointer >> checks that are extraneous because ..." 2/3 why, 1/3 what. > > Noted. Thanks. However, I was perhaps too subtle in asking you to actually explain why they were not needed. :) >>> - Fix memory leak >> >> Should this perhaps have been a separate commit? > > Probably. I'll be more careful next time. Awesome! Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/