From owner-svn-src-all@freebsd.org Mon Dec 12 22:38:13 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58526C742DE; Mon, 12 Dec 2016 22:38:13 +0000 (UTC) (envelope-from ken@kdm.org) Received: from mithlond.kdm.org (mithlond.kdm.org [96.89.93.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "A1-33714", Issuer "A1-33714" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D12A1AAF; Mon, 12 Dec 2016 22:38:12 +0000 (UTC) (envelope-from ken@kdm.org) Received: from mithlond.kdm.org (localhost [127.0.0.1]) by mithlond.kdm.org (8.15.2/8.14.9) with ESMTPS id uBCMXs55016492 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 12 Dec 2016 17:33:54 -0500 (EST) (envelope-from ken@mithlond.kdm.org) Received: (from ken@localhost) by mithlond.kdm.org (8.15.2/8.14.9/Submit) id uBCMXssu016491; Mon, 12 Dec 2016 17:33:54 -0500 (EST) (envelope-from ken) Date: Mon, 12 Dec 2016 17:33:54 -0500 From: "Kenneth D. Merry" To: Oliver Pinter Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307684 - head/sbin/camcontrol Message-ID: <20161212223354.GA16028@mithlond.kdm.org> References: <201610201942.u9KJgQOR062772@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mithlond.kdm.org [127.0.0.1]); Mon, 12 Dec 2016 17:33:54 -0500 (EST) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mithlond.kdm.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2016 22:38:13 -0000 On Sun, Dec 11, 2016 at 00:49:12 +0100, Oliver Pinter wrote: > On 10/20/16, Kenneth D. Merry wrote: > > Author: ken > > Date: Thu Oct 20 19:42:26 2016 > > New Revision: 307684 > > URL: https://svnweb.freebsd.org/changeset/base/307684 > > > > Log: > > For CCBs allocated on the stack, we need to clear the entire CCB, not > > just > > the header. Otherwise stack garbage can lead to random flags getting > > set. > > > > This showed up as 'camcontrol rescan all' failing with EINVAL because the > > address type wasn't CAM_DATA_VADDR. > > > > sbin/camcontrol/camcontrol.c: > > In rescan_or_reset_bus(), bzero the stack-allocated CCBs before > > use instead of clearing the body. > > > > MFC after: 3 days > > Sponsored by: Spectra Logic > > The MFC of this commit is missed both for 10-STABLE and 11-STABLE. Is > this still in plan to do? Done, thanks for the reminder! Ken -- Kenneth Merry ken@FreeBSD.ORG