Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Jan 2004 10:56:24 +0100
From:      "Miguel Mendez" <flynn@energyhq.es.eu.org>
To:        "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject:    ports/62101: [Maintainer Update] Add a patch to sysutils/gtk-send-pr
Message-ID:  <1075456584.0@scienide.energyhq.es.eu.org>
Resent-Message-ID: <200401301000.i0UA0YG1050279@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         62101
>Category:       ports
>Synopsis:       [Maintainer Update] Add a patch to sysutils/gtk-send-pr
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 30 02:00:34 PST 2004
>Closed-Date:
>Last-Modified:
>Originator:     Miguel Mendez
>Release:        DragonFly 1.0-CURRENT i386
>Organization:
The $699 Linux distro 
>Environment:


System: DragonFly scienide.energyhq.es.eu.org 1.0-CURRENT DragonFly 1.0-CURRENT #0: Thu J i386


>Description:


If the CC: field is empty, gtk-send-pr erroneously assumes that one CC: field should
be processed, and sets a NULL CC: field, which annoys some MTAs. 
This patch fixes the problem. Thanks to Ronald Klop for pointing this out.


>How-To-Repeat:





>Fix:


--- gtk-send-pr.diff begins here ---
diff -ruN gtk-send-pr.old/Makefile gtk-send-pr/Makefile
--- gtk-send-pr.old/Makefile	Fri Jan 30 03:31:11 2004
+++ gtk-send-pr/Makefile	Fri Jan 30 10:47:25 2004
@@ -2,11 +2,12 @@
 # Date created:			Fri May  2 22:08:08 CEST 2003
 # Whom:				Miguel Mendez <flynn@energyhq.es.eu.org>
 #
-# $FreeBSD: ports/sysutils/gtk-send-pr/Makefile,v 1.6 2004/01/30 02:31:11 clement Exp $
+# $FreeBSD: ports/sysutils/gtk-send-pr/Makefile,v 1.5 2004/01/17 21:01:22 clement Exp $
 #
 
 PORTNAME=	gtk-send-pr
 PORTVERSION=	0.3.2
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	http://www.energyhq.es.eu.org/files/
 
diff -ruN gtk-send-pr.old/files/patch-aa gtk-send-pr/files/patch-aa
--- gtk-send-pr.old/files/patch-aa	Thu Jan  1 01:00:00 1970
+++ gtk-send-pr/files/patch-aa	Fri Jan 30 10:47:32 2004
@@ -0,0 +1,38 @@
+--- gtk_ui.c.old	Thu Jan 29 21:16:44 2004
++++ gtk_ui.c	Fri Jan 30 10:43:42 2004
+@@ -21,7 +21,7 @@
+   OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ 
+-  $Id: //depot/gtk-send-pr/gtk_ui.c#10 $
++  $Id: //depot/gtk-send-pr/gtk_ui.c#11 $
+ 
+ */
+ 
+@@ -925,16 +925,19 @@
+ 
+   mypr->smtp_cc_text=(char *)gtk_entry_get_text(GTK_ENTRY(email_entry4));
+   cc_field=(char *)gtk_entry_get_text(GTK_ENTRY(email_entry4));
++  if(strlen(mypr->smtp_cc_text)>0) {
+ 
+-  do {
+-    temp_cc=strsep(&cc_field,",");
+-    if(temp_cc!=NULL) {
++    do {
++      temp_cc=strsep(&cc_field,",");
++      if(temp_cc!=NULL) {
+ 	
+-      mypr->smtp_cc[mypr->smtp_cc_num]=temp_cc;
+-      mypr->smtp_cc_num++;
+-    }
++	mypr->smtp_cc[mypr->smtp_cc_num]=temp_cc;
++	mypr->smtp_cc_num++;
++      }
++
++    } while(temp_cc!=NULL);
+ 
+-  } while(temp_cc!=NULL);
++  }
+ 
+   mypr->smtp_server=(char *)gtk_entry_get_text(GTK_ENTRY(email_entry8));
+   mypr->smtp_from=(char *)gtk_entry_get_text(GTK_ENTRY(email_entry2));
--- gtk-send-pr.diff ends here ---



>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1075456584.0>