From owner-svn-src-projects@freebsd.org Sat Aug 27 09:35:08 2016
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5583FB77CA8
for <svn-src-projects@mailman.ysv.freebsd.org>;
Sat, 27 Aug 2016 09:35:08 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (tensor.andric.com
[IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "tensor.andric.com",
Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 0D0D2EF0;
Sat, 27 Aug 2016 09:35:08 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from [IPv6:2001:7b8:3a7::4922:12d5:44e4:e815] (unknown
[IPv6:2001:7b8:3a7:0:4922:12d5:44e4:e815])
(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by tensor.andric.com (Postfix) with ESMTPSA id 27DCD1151;
Sat, 27 Aug 2016 11:35:04 +0200 (CEST)
Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: multipart/signed;
boundary="Apple-Mail=_6D8BEC0E-468F-45F7-84FB-5A82CBCBD4F7";
protocol="application/pgp-signature"; micalg=pgp-sha1
X-Pgp-Agent: GPGMail 2.6.1
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org>
Date: Sat, 27 Aug 2016 11:34:52 +0200
Cc: Ngie Cooper <yaneurabeya@gmail.com>,
"src-committers@freebsd.org" <src-committers@freebsd.org>,
"svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org>
Message-Id: <74FA03FF-2814-4FA5-863F-A4E86FC9A3CB@FreeBSD.org>
References: <201608262256.u7QMuNaZ037409@repo.freebsd.org>
<CAGHfRMCZ9Ma+9wfFJ+KFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com>
<A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org>
<CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg@mail.gmail.com>
<51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
X-Mailer: Apple Mail (2.3124)
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the src " projects"
tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Aug 2016 09:35:08 -0000
--Apple-Mail=_6D8BEC0E-468F-45F7-84FB-5A82CBCBD4F7
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
On 27 Aug 2016, at 03:37, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>
> On 8/26/2016 5:58 PM, Ngie Cooper wrote:
>> On Fri, Aug 26, 2016 at 4:39 PM, Dimitry Andric <dim@freebsd.org> wrote:
>> ...
>>> I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the
>>> latter didn't work for builds which are started during bootstrap-tools.
>>> So I locally reverted all these changes before committing this WIP.
...
>> Can you use something like this instead to signal the "right intent",
>> and someday hopefully this will just work (tm) with a bit more effort?
...
> SRCTOP should work just fine here. He did note that 'the latter'
> (OBJTOP) wouldn't work, since the early build likely is getting a normal
> build OBJTOP/tmp value for OBJTOP since it builds with
> MAKEOBJDIRPREFIX=${WORLDTMP}
Ok, I tried it and it does work as expected. During the early stages
(1.1 through 3), OBJTOP is defined as /usr/obj/usr/src/tmp/usr/src.
Then from stage 4.1 onwards it becomes /usr/obj/usr/src.
I've changed to SRCTOP and OBJTOP in r304884. It definitely looks a
bit neater.
-Dimitry
--Apple-Mail=_6D8BEC0E-468F-45F7-84FB-5A82CBCBD4F7
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.30
iEYEARECAAYFAlfBXswACgkQsF6jCi4glqOUbACfedeqe2hjGojY2hfemodd1SPV
B6EAnR5qMHbOelWremquyE2LVFYZ/gDB
=gfiI
-----END PGP SIGNATURE-----
--Apple-Mail=_6D8BEC0E-468F-45F7-84FB-5A82CBCBD4F7--