Date: Sat, 27 Aug 2016 11:34:52 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Ngie Cooper <yaneurabeya@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-projects@freebsd.org" <svn-src-projects@freebsd.org> Subject: Re: svn commit: r304868 - projects/clang390-import/lib/clang Message-ID: <74FA03FF-2814-4FA5-863F-A4E86FC9A3CB@FreeBSD.org> In-Reply-To: <51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org> References: <201608262256.u7QMuNaZ037409@repo.freebsd.org> <CAGHfRMCZ9Ma%2B9wfFJ%2BKFkP6KCr6vwE5CHP6fuyDgPvuzpd59PQ@mail.gmail.com> <A241E349-C7E3-490F-ADC9-D25ABCE956B6@FreeBSD.org> <CAGHfRMAYmeQHHnhTfN3GZkcGo9uhKnp_-DYmjANwtqqgkeo=dg@mail.gmail.com> <51c6c0cd-8809-76d8-bc07-1079e1e7a503@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_6D8BEC0E-468F-45F7-84FB-5A82CBCBD4F7
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
On 27 Aug 2016, at 03:37, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
>
> On 8/26/2016 5:58 PM, Ngie Cooper wrote:
>> On Fri, Aug 26, 2016 at 4:39 PM, Dimitry Andric <dim@freebsd.org> wrote:
>> ...
>>> I used ${SRCTOP} and ${OBJTOP} initially, until I realized that the
>>> latter didn't work for builds which are started during bootstrap-tools.
>>> So I locally reverted all these changes before committing this WIP.
...
>> Can you use something like this instead to signal the "right intent",
>> and someday hopefully this will just work (tm) with a bit more effort?
...
> SRCTOP should work just fine here. He did note that 'the latter'
> (OBJTOP) wouldn't work, since the early build likely is getting a normal
> build OBJTOP/tmp value for OBJTOP since it builds with
> MAKEOBJDIRPREFIX=${WORLDTMP}
Ok, I tried it and it does work as expected. During the early stages
(1.1 through 3), OBJTOP is defined as /usr/obj/usr/src/tmp/usr/src.
Then from stage 4.1 onwards it becomes /usr/obj/usr/src.
I've changed to SRCTOP and OBJTOP in r304884. It definitely looks a
bit neater.
-Dimitry
--Apple-Mail=_6D8BEC0E-468F-45F7-84FB-5A82CBCBD4F7
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.30
iEYEARECAAYFAlfBXswACgkQsF6jCi4glqOUbACfedeqe2hjGojY2hfemodd1SPV
B6EAnR5qMHbOelWremquyE2LVFYZ/gDB
=gfiI
-----END PGP SIGNATURE-----
--Apple-Mail=_6D8BEC0E-468F-45F7-84FB-5A82CBCBD4F7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?74FA03FF-2814-4FA5-863F-A4E86FC9A3CB>