From owner-cvs-all@FreeBSD.ORG Thu Sep 9 22:38:03 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80A331065696 for ; Thu, 9 Sep 2010 22:38:03 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 24EBF8FC1B for ; Thu, 9 Sep 2010 22:38:02 +0000 (UTC) Received: (qmail 10880 invoked by uid 399); 9 Sep 2010 22:38:01 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 9 Sep 2010 22:38:01 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C8961CA.5090402@FreeBSD.org> Date: Thu, 09 Sep 2010 15:38:02 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100825 Thunderbird/3.1.3 MIME-Version: 1.0 To: Koop Mast References: <201009091436.o89Ea4nO085960@repoman.freebsd.org> In-Reply-To: <201009091436.o89Ea4nO085960@repoman.freebsd.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/multimedia/webcamd Makefile distinfo ports/multimedia/webcamd/files webcamd.conf.in webcamd.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2010 22:38:03 -0000 There are 2 problems with the change in this patch. First, we prefer not to run code unconditionally in rc.d scripts, the hald_enable test should be in a start_precmd method. Second, testing for the existence of hald_enable is not sufficient, it could be set as "hald_enable=NO". The proper test is to use the rc.subr checkyesno function. hth, Doug On 9/9/2010 7:36 AM, Koop Mast wrote: > kwm 2010-09-09 14:36:04 UTC > > FreeBSD ports repository > > Modified files: > multimedia/webcamd Makefile distinfo > multimedia/webcamd/files webcamd.conf.in webcamd.in > Log: > Update to 0.1.16. > > - Add support for GNU/kFreeBSD > - Add support for DBUS/HAL registration > - Add support for more DVB tuner frontends > - Add support for multi-antenna DVB adapters > - Update to latest version of Linux DVB code > > Submitted by: maintainer > > Revision Changes Path > 1.8 +17 -2 ports/multimedia/webcamd/Makefile > 1.7 +3 -3 ports/multimedia/webcamd/distinfo > 1.4 +1 -1 ports/multimedia/webcamd/files/webcamd.conf.in > 1.4 +8 -2 ports/multimedia/webcamd/files/webcamd.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/Makefile.diff?&r1=1.7&r2=1.8&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/distinfo.diff?&r1=1.6&r2=1.7&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/files/webcamd.conf.in.diff?&r1=1.3&r2=1.4&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/files/webcamd.in.diff?&r1=1.3&r2=1.4&f=h > -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/