Date: Wed, 16 Apr 2003 20:26:53 +0900 (JST) From: Munehiro Matsuda <haro@kgt.co.jp> To: FreeBSD-gnats-submit@FreeBSD.org Cc: mbr@FreeBSD.org Subject: ports/51028: vmware3 port creates symlink under /etc Message-ID: <20030416.202653.41626303.haro@kgt.co.jp> Resent-Message-ID: <200304161130.h3GBU60Y044346@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 51028
>Category: ports
>Synopsis: vmware3 port creates symlink under /etc
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Apr 16 04:30:06 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator: Munehiro Matsuda
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
FreeBSD jkpc11.tt.kgt.co.jp 5.0-CURRENT FreeBSD 5.0-CURRENT #164: Wed Apr 16 13:48:08 JST 2003 haro@jkpc11.tt.kgt.co.jp:/home/haro/tmp/sys/i386/compile/NEWJKPC11 i386
vmware3 port version:
vmware3-3.2.0-2230_1
>Description:
1. vmware3 related symbolic link gets created under /etc, as /etc/vmware.
I don't like ports, that creates files under the base-system. ;-)
Better create it under /compat/linux/etc.
2. Makefile has hardcodes "/compat/linux"
>How-To-Repeat:
# /usr/ports/emulators/vmware3
# make install
# ls -l /etc/vmware
>Fix:
--- Makefile.ctm Wed Apr 16 16:03:23 2003
+++ Makefile Wed Apr 16 19:23:59 2003
@@ -203,9 +203,9 @@
.endif
post-install:
- ${LN} -sf ${PREFIX}/etc/vmware /etc/
- @if [ ! -e /compat/linux/usr/lib/vmware/bin/vmware ]; then \
- ${LN} -sf ${PREFIX}/lib/vmware /compat/linux/usr/lib/vmware; \
+ ${LN} -sf ${PREFIX}/etc/vmware ${LINUXBASE}/etc/
+ @if [ ! -e ${LINUXBASE}/usr/lib/vmware/bin/vmware ]; then \
+ ${LN} -sf ${PREFIX}/lib/vmware ${LINUXBASE}/usr/lib/vmware; \
fi
@${CAT} ${PKGMESSAGE}
--- pkg-plist.ctm Wed Apr 16 16:03:23 2003
+++ pkg-plist Wed Apr 16 19:21:07 2003
@@ -317,10 +317,10 @@
@exec chmod 666 %%LINUXBASE%%/dev/null
@exec mknod %%LINUXBASE%%/dev/hda b 0 0x00010002
@exec mknod %%LINUXBASE%%/dev/hdb b 0 0x0001000a
-@exec ln -sf %D/etc/vmware /etc/
+@exec ln -sf %D/etc/vmware %%LINUXBASE%%/etc/
@exec mknod %%LINUXBASE%%/dev/vmmon c 200 0
@exec mknod %%LINUXBASE%%/dev/vmnet1 c 149 %%VMNET1_MINOR%%
-@unexec rm -f /etc/vmware %%LINUXBASE%%/dev/vmmon %%LINUXBASE%%/dev/vmnet1 %%LINUXBASE%%/bin/df %%LINUXBASE%%/dev/tty[0-9]* %%LINUXBASE%%/dev/hd? %%LINUXBASE%%/dev/null
+@unexec rm -f %%LINUXBASE%%/etc/vmware %%LINUXBASE%%/dev/vmmon %%LINUXBASE%%/dev/vmnet1 %%LINUXBASE%%/bin/df %%LINUXBASE%%/dev/tty[0-9]* %%LINUXBASE%%/dev/hd? %%LINUXBASE%%/dev/null
@dirrm etc/vmware
@dirrm lib/vmware/bin
@dirrm lib/vmware/lib/help
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030416.202653.41626303.haro>