From owner-cvs-all Thu May 17 13:11:31 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 0C4F737B423; Thu, 17 May 2001 13:11:24 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f4HKBMP04018; Thu, 17 May 2001 21:11:22 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f4HKBLb68306; Thu, 17 May 2001 21:11:21 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200105172011.f4HKBLb68306@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Peter Wemm Cc: Ruslan Ermilov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/sys/sys sysctl.h In-Reply-To: Message from Peter Wemm of "Thu, 17 May 2001 12:22:46 PDT." <20010517192246.99AA8380A@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 17 May 2001 21:11:21 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Ruslan Ermilov wrote: > > ru 2001/05/17 10:57:37 PDT > > > > Modified files: > > sys/sys sysctl.h > > Log: > > Cosmetics to rev.1.89: removed argument names in a function prototype. > > It is also correct to merely move the names out of application > space. ie, change: > int foo(int *bar); > to: > int foo(int *_bar); > > For the bystanders, this is so that if somebody already has a macro: > #define bar 1 > then a later #include will fail due to: int foo(int *1); > Applications are perfectly entitled to do this. On a somewhat more esoteric note, when compiling with -Wshadow and using something like int foo(int link) you end up with a warning if you include unistd.h (it confuses ``link'' with the function prototype. This may be a compiler bug though :) > Cheers, > -Peter > -- > Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au > "All of this is for nothing if we don't go to the stars" - JMS/B5 -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message