From owner-svn-src-all@FreeBSD.ORG  Tue Oct 21 17:15:55 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 05F6FC36
 for <svn-src-all@freebsd.org>; Tue, 21 Oct 2014 17:15:55 +0000 (UTC)
Received: from mail-pd0-x22c.google.com (mail-pd0-x22c.google.com
 [IPv6:2607:f8b0:400e:c02::22c])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CE994AF7
 for <svn-src-all@freebsd.org>; Tue, 21 Oct 2014 17:15:54 +0000 (UTC)
Received: by mail-pd0-f172.google.com with SMTP id ft15so1729746pdb.17
 for <svn-src-all@freebsd.org>; Tue, 21 Oct 2014 10:15:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=references:mime-version:in-reply-to:content-type
 :content-transfer-encoding:message-id:cc:from:subject:date:to;
 bh=+SnSnvLOKhBqHmckUs50WDuru3IUcRmsdW4SjEGyXLY=;
 b=h/g9aao8eX1jIknFrIm3FN1LEhBK5VBoVAgmSHDl6KK+OmXOqMXjmsHBfjwtBREW3H
 OSJh8CFGO+6lztWP6j45h7xY/exJbEpJyN7MkCESnvESw+3hzkNgBElYNQyKO8MkOZVH
 IkXi04m/TE1U+RykDZk95xvDILtAurjFmjVUX7/0y/Ee+WiwuXukKHyUJGvNzm+aHvMG
 1Dz4tFYS2D81tpzkvIKPw75tux+sf7yVWKyGzlSnbMA2BeCxVzVU0CjugABOCbImQLbF
 5GxLGDUarZyK+Ng2AfxS6RMu879S6uhUvhhYFDVhJWcrmgEZVTgHl9h7YDcced3aNS3h
 T9mw==
X-Received: by 10.70.47.132 with SMTP id d4mr13254553pdn.59.1413911754446;
 Tue, 21 Oct 2014 10:15:54 -0700 (PDT)
Received: from [192.168.20.11] (c-98-247-240-204.hsd1.wa.comcast.net.
 [98.247.240.204])
 by mx.google.com with ESMTPSA id t11sm12374790pdj.89.2014.10.21.10.15.53
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 21 Oct 2014 10:15:53 -0700 (PDT)
References: <201410130033.s9D0XxVu081401@svn.freebsd.org>
 <1B16315B-B1B2-48D4-94FA-FF92802F7A3F@gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <1B16315B-B1B2-48D4-94FA-FF92802F7A3F@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-Id: <8C1C24C1-9BD7-4425-957F-DD96E83FE7CD@gmail.com>
X-Mailer: iPhone Mail (11D257)
From: Garrett Cooper <yaneurabeya@gmail.com>
Subject: Re: svn commit: r273017 - head/contrib/netbsd-tests/lib/libc/locale
Date: Tue, 21 Oct 2014 10:15:51 -0700
To: Warner Losh <imp@bsdimp.com>
Cc: svn-src-all@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Oct 2014 17:15:55 -0000


> On Oct 21, 2014, at 8:22, Warner Losh <imp@bsdimp.com> wrote:
>=20
> Any reason you added #fidefs around this? It is needed on NetBSD too :)

Agreed. NetBSD seems to work thanks to header pollution though.

I opened several upstream PRs to fix #include issues. The #ifdefs make it cl=
ear how the tests differ (and for me what needs to be pushed back).

Thanks!=