Date: Sun, 9 Feb 1997 06:38:35 +1100 From: Bruce Evans <bde@zeta.org.au> To: freebsd-hackers@FreeBSD.ORG, j@uriah.heep.sax.de Subject: Re: Panic in probe, but no dump Message-ID: <199702081938.GAA23616@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>Btw., i found when code-reviewing that part that it only wants to dump
>into partition `b' of some device. Everything else is silently
>discarded:
>
>static void
>dumpsys(void)
>{
>
> if (!dodump)
> return;
> if (dumpdev == NODEV)
> return;
> if ((minor(dumpdev)&07) != 1)
> ^^^^
> return;
>
Ugh. The only excuse for doing that is that the dumpdev that was
carefully checked by setdumpdev() may be stale (if it is on removable
media). Another reason for using a swap device is that swap devices
can't be stale - they are held open, and if they are removed, then you
have worse problems :-].
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199702081938.GAA23616>