From owner-freebsd-current@freebsd.org Thu May 19 02:02:00 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2A30B3FE52 for ; Thu, 19 May 2016 02:02:00 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7EABD10D0 for ; Thu, 19 May 2016 02:02:00 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: by mailman.ysv.freebsd.org (Postfix) id 7E07EB3FE51; Thu, 19 May 2016 02:02:00 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DAE9B3FE50 for ; Thu, 19 May 2016 02:02:00 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: from mail-oi0-x230.google.com (mail-oi0-x230.google.com [IPv6:2607:f8b0:4003:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4901110CE for ; Thu, 19 May 2016 02:01:59 +0000 (UTC) (envelope-from ian.freislich@capeaugusta.com) Received: by mail-oi0-x230.google.com with SMTP id x201so106682522oif.3 for ; Wed, 18 May 2016 19:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=capeaugusta-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=6Zhtfj5GjdkewdrIqLhE178EcoFKQ98c/wvKTxYoxWQ=; b=hvoVdOXOzG7z9/GeNMPn9eQkbsWJGeqQ9sdP+bAL9kr/xpoWISAGtDlm2K+RW57aPS IWr+B0YsKCD13i6KYZYZ7YpaVpOO+7toAcQJUrtZc3nQ607DcaP0Ek4cHy8xn+M6YeJA 1pfychsi0xwyvrgXWImxJpoG8z71EZfVRZxlovufYgZur+YO76Ljwh8qBLEkYpY6ETGo JTYcbJQ3bavh04FWCS5pjFnkmugWhf/ALD3WZNegNfmiMdPEV5okqUyZkGslCEl0+PKA KCbJRrN1maQMweVAZZM2w6GdeceQtzdEk+2iJ7zMpFCXihYfU1wc65Ez+6kD9Nwdfjyu hwTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=6Zhtfj5GjdkewdrIqLhE178EcoFKQ98c/wvKTxYoxWQ=; b=eqIOgctWovdRBnf0I3EYpxxO4V72J8xB86zNV8HQjL9x+VSqy1zTgvSU6omMGcQhKU 3Sv1O4zaEyVpulEouNa7h/WIPPo928dyiQfWCmJchcL7IMZZOXV+V+zAv7UBE/s2xuBw JecAqmmpJR7rQHzd0r4QSlOEWwcaHMhHCr6yDBW3/IVqCmK1kMn8Ad6K0fkvD/kjkSW0 901krOcCTKkdBITwJA8qoUbi5H2bYuRG/j0TCZBqgSVwywjkta/AQEKSWJQs+8ue63dz UQf2FSJOSdbclKBS1QNiPRBR/QkVb8Xb+ENdxybwGH/Yk49LOqCPD0na4xO8ZgomqrcA LIDg== X-Gm-Message-State: AOPr4FVDSE9i0cOe0EQ/GVVrNu+KeYsiylky+ROuZxBeYti1A2eCPeA7dNSgqt3zsZ2RwMZ0lXp4msPD7yg8mT8SycDVvUN7E4YD6NcqlfJFTcb/zpEJ72lRPm9gKUGmCR+1O4968DoYzovXDXq0dlhfYF9RytMnqRE+dwz4mBTPaYJPiLig13X1Rw5Q/AbktQ== X-Received: by 10.157.6.12 with SMTP id 12mr6665987otn.43.1463623318643; Wed, 18 May 2016 19:01:58 -0700 (PDT) Received: from zen.clue.co.za (c-71-226-15-200.hsd1.ga.comcast.net. [71.226.15.200]) by smtp.gmail.com with ESMTPSA id 60sm3212076ott.13.2016.05.18.19.01.57 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 May 2016 19:01:58 -0700 (PDT) Subject: Re: r299512 breaks dhclient on some networks To: cem@FreeBSD.org References: <15379a54-3e6e-2c2c-b41c-8def3af65bad@capeaugusta.com> Cc: current From: Ian FREISLICH Message-ID: Date: Wed, 18 May 2016 22:01:56 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 02:02:00 -0000 On 05/18/16 19:49, Conrad Meyer wrote: > Hey Ian, > > r299512 incorrectly encoded client identifiers because I misunderstood > the intent of the sizeof()-scaled client_id. I reverted that change > and replaced it with r300174, which I believe fixes the first overrun > more correctly. Just checked and DHCP is working again. > (Coverity may still complain about CID 1305550, but I don't believe > it's valid for 'hlen' to exceed sizeof(hw_addr.haddr).) > > Thanks, > Conrad > > On Wed, May 18, 2016 at 3:49 PM, Ian FREISLICH > wrote: >> Hi >> >> I cannot for the life of me figure out why the change in r299512 breaks >> DHCP on one network I use but not on another network. >> >> The only clue I can find is that the request whose response is ignored >> has the following client ID: >> 1:6:0:22:5f:70:a1:df >> >> The request whose response is use has this client ID: >> 1:0:22:5f:70:a1:df >> >> Here's a dhcpdump of the request/offer that gets ignored. >> >> --------------------------------------------------------------------------- >> >> TIME: 2016-05-18 18:46:39.134 >> IP: 0.0.0.0 (00:22:5f:70:a1:df) > 255.255.255.255 (ff:ff:ff:ff:ff:ff) >> OP: 1 (BOOTPREQUEST) >> HTYPE: 1 (Ethernet) >> HLEN: 6 >> HOPS: 0 >> XID: 92a34fc3 >> SECS: 0 >> FLAGS: 0 >> CIADDR: 0.0.0.0 >> YIADDR: 0.0.0.0 >> SIADDR: 0.0.0.0 >> GIADDR: 0.0.0.0 >> CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 >> SNAME: . >> FNAME: . >> OPTION: 53 ( 1) DHCP message type 1 (DHCPDISCOVER) >> OPTION: 61 ( 8) Client-identifier 01:06:00:22:5f:70:a1:df >> OPTION: 12 ( 3) Host name zen >> OPTION: 55 ( 9) Parameter Request List 1 (Subnet mask) >> 28 (Broadcast address) >> 2 (Time offset) >> 121 (Classless Static Route) >> 3 (Routers) >> 15 (Domainname) >> 6 (DNS server) >> 12 (Host name) >> 119 (Domain Search) >> >> --------------------------------------------------------------------------- >> >> TIME: 2016-05-18 18:46:39.134 >> IP: 10.0.0.1 (4c:5e:0c:62:4f:82) > 10.0.0.80 (00:22:5f:70:a1:df) >> OP: 2 (BOOTPREPLY) >> HTYPE: 1 (Ethernet) >> HLEN: 6 >> HOPS: 0 >> XID: 92a34fc3 >> SECS: 0 >> FLAGS: 0 >> CIADDR: 0.0.0.0 >> YIADDR: 10.0.0.80 >> SIADDR: 10.0.0.1 >> GIADDR: 0.0.0.0 >> CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 >> SNAME: . >> FNAME: . >> OPTION: 53 ( 1) DHCP message type 2 (DHCPOFFER) >> OPTION: 54 ( 4) Server identifier 10.0.0.1 >> OPTION: 51 ( 4) IP address leasetime 259200 (3d) >> OPTION: 1 ( 4) Subnet mask 255.255.255.0 >> OPTION: 3 ( 4) Routers 10.0.0.1 >> OPTION: 6 ( 4) DNS server 10.0.0.1 >> --------------------------------------------------------------------------- >> >> >> And here's the request/offer that works (with the r299512 backed out) >> >> --------------------------------------------------------------------------- >> >> TIME: 2016-05-18 18:35:33.817 >> IP: 10.0.0.220 (00:22:5f:70:a1:df) > 255.255.255.255 (ff:ff:ff:ff:ff:ff) >> OP: 1 (BOOTPREQUEST) >> HTYPE: 1 (Ethernet) >> HLEN: 6 >> HOPS: 0 >> XID: 866cfd85 >> SECS: 4 >> FLAGS: 0 >> CIADDR: 0.0.0.0 >> YIADDR: 0.0.0.0 >> SIADDR: 0.0.0.0 >> GIADDR: 0.0.0.0 >> CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 >> SNAME: . >> FNAME: . >> OPTION: 53 ( 1) DHCP message type 3 (DHCPREQUEST) >> OPTION: 50 ( 4) Request IP address 10.0.0.220 >> OPTION: 61 ( 7) Client-identifier 01:00:22:5f:70:a1:df >> OPTION: 12 ( 3) Host name zen >> OPTION: 55 ( 9) Parameter Request List 1 (Subnet mask) >> 28 (Broadcast address) >> 2 (Time offset) >> 121 (Classless Static Route) >> 3 (Routers) >> 15 (Domainname) >> 6 (DNS server) >> 12 (Host name) >> 119 (Domain Search) >> >> --------------------------------------------------------------------------- >> >> TIME: 2016-05-18 18:35:33.817 >> IP: 10.0.0.1 (4c:5e:0c:62:4f:82) > 10.0.0.220 (00:22:5f:70:a1:df) >> OP: 2 (BOOTPREPLY) >> HTYPE: 1 (Ethernet) >> HLEN: 6 >> HOPS: 0 >> XID: 866cfd85 >> SECS: 0 >> FLAGS: 0 >> CIADDR: 0.0.0.0 >> YIADDR: 10.0.0.220 >> SIADDR: 10.0.0.1 >> GIADDR: 0.0.0.0 >> CHADDR: 00:22:5f:70:a1:df:00:00:00:00:00:00:00:00:00:00 >> SNAME: . >> FNAME: . >> OPTION: 53 ( 1) DHCP message type 5 (DHCPACK) >> OPTION: 54 ( 4) Server identifier 10.0.0.1 >> OPTION: 51 ( 4) IP address leasetime 259200 (3d) >> OPTION: 1 ( 4) Subnet mask 255.255.255.0 >> OPTION: 3 ( 4) Routers 10.0.0.1 >> OPTION: 6 ( 4) DNS server 10.0.0.1 >> --------------------------------------------------------------------------- >> >> >> >> -- >> Ian Freislich >> >> >> -- >> >> >> Cape Augusta Digital Properties, LLC a Cape Augusta Company >> >> *Breach of confidentiality & accidental breach of confidentiality * >> >> This email and any files transmitted with it are confidential and intended >> solely for the use of the individual or entity to whom they are addressed. >> If you have received this email in error please notify the system manager. >> This message contains confidential information and is intended only for the >> individual named. If you are not the named addressee you should not >> disseminate, distribute or copy this e-mail. Please notify the sender >> immediately by e-mail if you have received this e-mail by mistake and >> delete this e-mail from your system. If you are not the intended recipient >> you are notified that disclosing, copying, distributing or taking any >> action in reliance on the contents of this information is strictly >> prohibited. >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" -- Ian Freislich -- Cape Augusta Digital Properties, LLC a Cape Augusta Company *Breach of confidentiality & accidental breach of confidentiality * This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.