From owner-svn-src-all@freebsd.org Tue Nov 6 17:12:17 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3B4A112A6D7; Tue, 6 Nov 2018 17:12:16 +0000 (UTC) (envelope-from markiyan.kushnir@gmail.com) Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25B3880DC3; Tue, 6 Nov 2018 17:12:16 +0000 (UTC) (envelope-from markiyan.kushnir@gmail.com) Received: by mail-io1-xd32.google.com with SMTP id k17-v6so9779008ioc.4; Tue, 06 Nov 2018 09:12:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pHgnMCGJpKT6g4SyBspUTfvd6PJQ11lT7IgEFFTshvI=; b=INdMCzXbMJn4c16zLttTAAv2KT7NTx2/ftButRzdb/pwzASVVErEz6M1lDGc8vZmiB L/SpM4FVtqcruZnZZuz1hL00lBboDPE/QeTiOvMmHtOsdxCaha0N1cSjBXDb171rUFlu fexiCygni86BtIce3RA2mnDNMme9Bwh8FI4stJ8jZyhwJ8cJ3B2l1IplwhV3K0yNW9Vm mlI/CsUPNNA04KwQLkIUAGYiSrUdBFfebCWmgV71kcQ/qm9qZhaGrp8H3jeaMfGdE1yY 00LacC3pF80e1oEIop3OUbzlUxfzDERQPnfv+ftqFQ0ymlzlGNIshnaAGPwd6AfBCFal f3XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pHgnMCGJpKT6g4SyBspUTfvd6PJQ11lT7IgEFFTshvI=; b=azsvZCnKz/nnoQ9nKVoaGI2DwRHVx05yeKxm9ABVB5HX8IGL3SiL7MZ9a+PtFBQXIW hosGDUqKxrAz/DyScxm5knAtFTeFmEkMQfLU0ZTI4SUYf1QE5ya1F8t83Sn9b0sfHC3M pvUVMWdKIF00NUa5NazwMd7xuIW77JZB6lNTY8OrvimOu9XKnjroRodkxcbNwJff4vVe q+L1LBczuXxvbadDtBavthXJMYe8xvX+5/qfvAH90ywb1PivOwXKwt20pO2jLexpVK9U X41hYmaP98N0fdqjgQBDc2/FxOaa+uNftOkcvHg6dym6h8R/GLJn0UQSvviYDB3qrH4S nc/g== X-Gm-Message-State: AGRZ1gL8SicV8Nzdgk54e2F6hiDA9gy+4sCfIgBjYBYIjs4yk7SgE7fx enYmtQcOlwoQ1fZhLxkhioDGjo7L24a0fPO0VKLEWSF1 X-Google-Smtp-Source: AJdET5fLzzay5r3mgz/Du/Sg022ccliB5wxo6UIFUKC94cb03nJLkkkjtOeXzD8Li9T9vmPAXOZoZ6pmO0HkKzUwPE4= X-Received: by 2002:a6b:5503:: with SMTP id j3-v6mr21042952iob.209.1541524335159; Tue, 06 Nov 2018 09:12:15 -0800 (PST) MIME-Version: 1.0 References: <201810230631.w9N6VPR4008554@repo.freebsd.org> <9612d267-91dc-b1ee-7530-284376f08f08@FreeBSD.org> In-Reply-To: From: Markiyan Kushnir Date: Tue, 6 Nov 2018 19:12:03 +0200 Message-ID: Subject: Re: svn commit: r339636 - in head: . share/mk To: arichardson@freebsd.org Cc: bdrewery@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-Rspamd-Queue-Id: 25B3880DC3 X-Spamd-Result: default: False [-3.42 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.963,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.994,0]; URI_COUNT_ODD(1.00)[15]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-0.54)[ipnet: 2607:f8b0::/32(-1.25), asn: 15169(-1.39), country: US(-0.08)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.90)[-0.904,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 17:12:17 -0000 Alexander, Cannot tell exactly what change it was, might be one of your recent changes to bsd.compiler.mk or Makefile.inc1? ... Now running "make buildworld" I can proceed with "3.1: recording build metadata" only having USING_SYSTEM_COMPILER=3Dyes USING_SYSTEM_LINKER=3Dyes= set in my environment. Otherwise I'm getting this: sh: cc: not found make[2]: "/work/src.svn/share/mk/bsd.compiler.mk" line 176: Unable to determine compiler type for CC=3Dcc -target x86_64-unknown-freebsd13.0 --sysroot=3D//usr/obj/work/src.svn/amd64.amd64/tmp -B//usr/obj/work/src.svn/amd64.amd64/tmp/usr/bin. Consider setting COMPILER_TYPE. *** Error code 1 Stop. make[1]: stopped in /work/src.svn *** Error code 1 Stop. make: stopped in /work/src.svn Failed to build world I'm at rev. 340189. Could you please have a look? -- Markiyan =D0=B2=D1=82, 6 =D0=BB=D0=B8=D1=81=D1=82. 2018 =D0=BE 01:11 Alexander Richa= rdson =D0=BF=D0=B8=D1=88=D0=B5: > On Mon, 5 Nov 2018 at 23:00, Bryan Drewery wrote: > > > > On 10/22/2018 11:31 PM, Alex Richardson wrote: > > > Author: arichardson > > > Date: Tue Oct 23 06:31:25 2018 > > > New Revision: 339636 > > > URL: https://svnweb.freebsd.org/changeset/base/339636 > > > > > > Log: > > > Only compute the X_COMPILER_*/X_LINKER_* variables when needed > > > > > > When building CheriBSD we have to set XLD/XCC/XCFLAGS on the comman= d > line. > > > This triggers the $XCC !=3D $CC case in bsd.compiler.mk (and the sa= me > for LD > > > in bsd.linker.mk) which causes it to call ${XCC} --version and > > > ${XLD} --version (plus various awk+sed+echo calls) in every > subdirectory. > > > For incremental builds and stages that only walk the source tree > this is > > > often the majority of the time spent in that directory. > > > > > ... > > > > > By only computing the value of the X_COMPILER_*/X_LINKER_* variable= s > if > > > _WANT_TOOLCHAIN_CROSS_VARS is set we can reduce the number of cc/ld > calls > > > to once per build stage instead of once per recursive make. > > > > This sounds wrong. bsd.compiler.mk *already* handles that kind of thing > > by exporting its computations. Adding a second hack for a similar > > problem isn't the right solution. > > > > I added debug .info statements for every time bsd.compiler.mk was > running cc --version and it was always running it for $XCC during make > buildworld. > As far as I can tell this happens because $CC and $XCC no longer match. > I believe the problem is that the toplevel makefile runs the cross > stages with CC=3D"${XCC} ${XCFLAGS}" so if you have XCFLAGS set in your > environment $CC will never be equal to $XCC. > This also means there is not cached variable for $XCC since it was > computed for "${XCC} ${XCFLAGS}" rather than $XCC . > > This patch massively reduced the incremental build time for CheriBSD > but if you can suggest I better fix that would be great. > > Alex > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >