From owner-cvs-all@FreeBSD.ORG Sun Apr 3 05:57:09 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69D6B1065670; Sun, 3 Apr 2011 05:57:09 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30]) by mx1.freebsd.org (Postfix) with ESMTP id 433858FC17; Sun, 3 Apr 2011 05:57:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by spartan.hamla.org (Postfix) with ESMTP id C97BD1713A; Sun, 3 Apr 2011 01:57:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:reply-to:message-id :subject:subject:from:from:date:date:received:received; s=aegis; t=1301810228; bh=nES2UWCvGLQZw3/8E6yXD8R3tj91RoYoDlFsjTVSNYs=; b= T9vvI1OqPtmN/aRO4KOlCQHhbbix46jwAepXjN5XffKmlusYYWIxp7Lz7BzTCGdl NKCvE4TuJ4SYYvDXsZmwVZ6NBXpXs64lQuTakAF4PFnn7ChnjTdK+whdAMM78Qp4 B6k3NUohk4k7A9o75cMa/cmYQhSUmtmtod1fz7bZ+8Y= X-Virus-Scanned: by ClamAV at spartan.hamla.org Received: from spartan.hamla.org ([127.0.0.1]) by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027) with LMTP id KHeCxeeX8KgE; Sun, 3 Apr 2011 01:57:08 -0400 (EDT) Received: from magic.hamla.org (cpe-69-201-179-80.nyc.res.rr.com [69.201.179.80]) by spartan.hamla.org (Postfix) with ESMTPSA id ED80817113; Sun, 3 Apr 2011 01:57:06 -0400 (EDT) Date: Sun, 3 Apr 2011 01:57:04 -0400 From: Sahil Tandon To: Doug Barton Message-ID: <20110403055703.GA81066@magic.hamla.org> References: <201104021205.p32C5Y8g082718@repoman.freebsd.org> <20110402155230.GA80090@magic.hamla.org> <4D978D14.406@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D978D14.406@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Dirk Meyer , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/netpbm Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sahil Tandon List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2011 05:57:09 -0000 On Sat, 2011-04-02 at 13:54:44 -0700, Doug Barton wrote: > On 04/02/2011 08:52, Sahil Tandon wrote: > >On Sat, 2011-04-02 at 12:05:34 +0000, Dirk Meyer wrote: > > > >>dinoex 2011-04-02 12:05:34 UTC > >> > >> FreeBSD ports repository > >> > >> Modified files: > >> graphics/netpbm Makefile > >> Log: > >> - drop CONFLICTS with megetty > >> Submitted by: olgeni > > > >Does PORTREVISION need to be bumped when we change CONFLICTS? > > When adding CONFLICTS I would say definitely yes, since they are > recorded in the package. When dropping a conflict I personally would > be less inclined to bump it, unless I knew that there was an > existing problem that is being solved by the update. I share your rationale for the most part, but I am still unclear about what some might call an 'edge' case. To wit, let us assume that I already have port foo installed; foo conflicts with bar (as noted in CONFLICTS within bar's Makefile). Therefore, whenever I try to install bar, I am notified about the conflict and unable to proceed. A few months pass, and for whatever reason, the bar maintainer removes the conflict with foo, but does not bump PORTREVISION. The default bar package, from whichever repository I had originally obtained it, will still contain the (now incorrect) conflict with foo. Is my understanding or interpretation of this example flawed? Does this type of situation occur so seldom that it is not worth the bump in the majority of cases when a conflict is dropped? Should we similarly not bump PORTREVISION if something is dropped from RUN_DEPENDS (which, like CONFLICTS, is recorded in the package)? Or perhaps I've missed a nuance that makes my question foolish. In any case, please bludgeon me with a cluebat so I stop pestering you with these questions. :-) -- Sahil Tandon