From owner-freebsd-current@FreeBSD.ORG Wed May 28 08:20:37 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0BA437B401 for ; Wed, 28 May 2003 08:20:37 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 28D5D43F85 for ; Wed, 28 May 2003 08:20:35 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h4SFJjOn064134; Wed, 28 May 2003 11:19:45 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)h4SFJj3X064131; Wed, 28 May 2003 11:19:45 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Wed, 28 May 2003 11:19:45 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: David Malone In-Reply-To: <20030528150524.GA40895@lanczos.maths.tcd.ie> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@FreeBSD.org Subject: Re: mb alloc and: panic: mutex Giant not owned at ../../../vm/vm_kern.c:315 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 May 2003 15:20:38 -0000 On Wed, 28 May 2003, David Malone wrote: > On Wed, May 28, 2003 at 10:06:14AM -0400, Robert Watson wrote: > > I haven't seen this panic previously; a lack of Giant coming out of the > > socket code is a bit surprising to me, but I think is unlikely to be a > > result of our local MAC tweaks. > > This may be my fault, as I made some changes recently that assumed that > the mbuf allocator grabbed giant when needed. I'll check the code path > you've mentioned to see if it grabs giant now, but I suspect that I just > need to move the giant grabbing back where it was before. This doesn't seem to be a reproduceable problem for me, FWIW, (presumably a property of bucket sizes, etc) so you have all the information I have :-). If possible, we should get this fix in for 5.1? Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories