From owner-freebsd-eclipse@FreeBSD.ORG Thu Sep 15 13:02:32 2005 Return-Path: X-Original-To: freebsd-eclipse@freebsd.org Delivered-To: freebsd-eclipse@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 26B5316A41F for ; Thu, 15 Sep 2005 13:02:32 +0000 (GMT) (envelope-from past@ebs.gr) Received: from fly.ebs.gr (fly.ebs.gr [62.103.84.177]) by mx1.FreeBSD.org (Postfix) with ESMTP id D33A043D46 for ; Thu, 15 Sep 2005 13:02:30 +0000 (GMT) (envelope-from past@ebs.gr) Received: from ebs.gr (root@hal.ebs.gr [10.1.1.2]) by fly.ebs.gr (8.12.9p1/8.12.9) with ESMTP id j8FD2R9V010147; Thu, 15 Sep 2005 16:02:27 +0300 (EEST) (envelope-from past@ebs.gr) Received: from [10.1.1.158] (pc158.ebs.gr [10.1.1.158]) by ebs.gr (8.13.3/8.12.11) with ESMTP id j8FD2WWh088309; Thu, 15 Sep 2005 16:02:33 +0300 (EEST) (envelope-from past@ebs.gr) Message-ID: <432970D7.1070008@ebs.gr> Date: Thu, 15 Sep 2005 16:02:15 +0300 From: Panagiotis Astithas Organization: EBS Ltd. User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050830) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andreas Kohn References: <4329166F.30106@ebs.gr> <1126779168.990.10.camel@klamath.syndrom23.de> In-Reply-To: <1126779168.990.10.camel@klamath.syndrom23.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "barbara.xxx1975" , freebsd-eclipse Subject: Re: java/eclipse: error building WITH_MOZILLA=mozilla X-BeenThere: freebsd-eclipse@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps & ports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 13:02:32 -0000 Andreas Kohn wrote: > Hi, > > On Thu, 2005-09-15 at 09:36 +0300, Panagiotis Astithas wrote: > >>barbara.xxx1975 wrote: >> >>>port version: >>># $FreeBSD: ports/java/eclipse/Makefile,v 1.38 2005/09/14 14:46:36 nork Exp $ >>> >>>I keep getting an error if I try to upgrade(from eclipse-3.1_1) or build eclipse with WITH_MOZILLA=mozilla. >>>This doesn't happen if I use the WITH_MOZILLA=firefox. >>> >>>*UPDATE* (this happened while I was writing): >>>When I tryed to build eclipse WITH_MOZILLA=mozilla these ports where not installed: >>>nspr-4.6_1 >>>nss-3.10 >>>firefox-1.0.6_5,1 >>>I had them installed to try with WITH_MOZILLA=firefox. >>>Now it builds also with WITH_MOZILLA=mozilla. >>>As eclipse does not run-depends on them, could I safely pkg_delete them? >>>Or should I keep them to avoid to install them again on the next eclipse upgrade? >> >>You are not supposed to ever use WITH_MOZILLA=mozilla. > > I don't like this at all. WITH_MOZILLA=mozilla is a perfectly valid > setting for other mozilla-using ports, and people probably have their > preference in /etc/make.conf (I do). Never heard of that before. Can you mention the ports that have such a complete logic that can handle all variations? I'd like to copy their logic. > Please see attached patch (line numbers may be off, hand-edited). > > Regards, > Andreas > > > > ------------------------------------------------------------------------ > > Index: Makefile > =================================================================== > RCS file: /storage/freebsd/cvs/ports/java/eclipse/Makefile,v > retrieving revision 1.36 > diff -u -r1.36 Makefile > --- Makefile 28 Aug 2005 15:29:49 -0000 1.36 > +++ Makefile 15 Sep 2005 10:09:20 -0000 > @@ -44,7 +44,7 @@ > .else > ECLIPSE_WS= gtk > .if !defined(WITHOUT_MOZILLA) > -.if defined(WITH_MOZILLA) > +.if defined(WITH_MOZILLA) && ${WITH_MOZILLA} != "mozilla" > BROWSER= ${WITH_MOZILLA} > MAKE_MOZILLA= make_mozilla > BUILD_DEPENDS+= ${BROWSER}:${PORTSDIR}/www/${BROWSER} > If there is no better alternative, I'm ok with this. Regards, Panagiotis