From owner-svn-src-all@FreeBSD.ORG Thu Nov 29 00:39:06 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C59747FE; Thu, 29 Nov 2012 00:39:06 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id B4F188FC08; Thu, 29 Nov 2012 00:39:05 +0000 (UTC) Received: by mail-wg0-f50.google.com with SMTP id 12so1910350wgh.31 for ; Wed, 28 Nov 2012 16:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=moew9CWavpDAZ+8fRZU/C3//+P+aKt5SW9CXYJhJ0WI=; b=UwAtodlCZf8cOJoOtv9FwxsssfHVN+OP3yMbRjtDu0SHUDXy7V8j8QXRi0Ini/cRGa qJdM55pNNcM5S/ZXbfb4ATw5vcXdZJSyNxxXJULeM5POHTs9np970SU2WlqLChsuigaK pUr/aTHlQc/DOWyprkZwMFvnaxqaPHAgHJI8D71iCvMqkXT6nc+UvN5rU0Ac9jxbrHNi 1MkHuUiNIE41YnjxrgOXC7it+i+09Fa3Hx0P3tYNeWX0U+LMJ0uP50N3pp7BVeEFGDGH Wqw1i4zD7Xn1Sdm4W4ztun28JaBpF9ZRkesIaepomFHbd6EhcqQsRF2ps/S8KWynSF9R SP7g== Received: by 10.216.209.130 with SMTP id s2mr8658303weo.86.1354149544517; Wed, 28 Nov 2012 16:39:04 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPS id d9sm9475242wiw.0.2012.11.28.16.39.02 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 28 Nov 2012 16:39:03 -0800 (PST) Date: Thu, 29 Nov 2012 01:38:53 +0100 From: Mateusz Guzik To: Rick Macklem Subject: Re: svn commit: r243645 - head/usr.sbin/nfsd Message-ID: <20121129003853.GB22327@dft-labs.eu> References: <20121128122034.GB17871@dft-labs.eu> <460700956.954956.1354148063432.JavaMail.root@erie.cs.uoguelph.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <460700956.954956.1354148063432.JavaMail.root@erie.cs.uoguelph.ca> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Alfred Perlstein X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2012 00:39:06 -0000 On Wed, Nov 28, 2012 at 07:14:23PM -0500, Rick Macklem wrote: > Mateusz Guzik wrote: > > On Wed, Nov 28, 2012 at 02:47:32AM +0000, Alfred Perlstein wrote: > > > Author: alfred > > > Date: Wed Nov 28 02:47:31 2012 > > > New Revision: 243645 > > > URL: http://svnweb.freebsd.org/changeset/base/243645 > > > > > > Log: > > > Don't allow minthreads > maxthreads. > > > > > Should not this be also checked in the kernel? Looks like nfssvc_nfsd > > is > > trustful: > > > Well, since only root can do this and I can't think of why a sysadmin > would use anything other than nfsd, I'm not sure it matters much? > (But I don't see a problem with adding a sanity check in the kernel code.) > It's nothing serious and I'm not going to insist, especially since this is your code. I just prefer the kernel to be resistant if it does not cost much. I had something like this in mind (untested): http://people.freebsd.org/~mjg/patches/nfs-threads-check.diff -- Mateusz Guzik