From owner-freebsd-current@FreeBSD.ORG Wed Mar 10 14:33:13 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E08416A4CE for ; Wed, 10 Mar 2004 14:33:13 -0800 (PST) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5BE3743D41 for ; Wed, 10 Mar 2004 14:33:13 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 22358 invoked from network); 10 Mar 2004 22:33:12 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 10 Mar 2004 22:33:12 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i2AMWt2D031666; Wed, 10 Mar 2004 17:33:08 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Bruce Evans Date: Wed, 10 Mar 2004 17:34:08 -0500 User-Agent: KMail/1.6 References: <7m7jxth70h.wl@black.imgsrc.co.jp> <200403101309.32292.jhb@FreeBSD.org> <20040311054522.T2459@gamplex.bde.org> In-Reply-To: <20040311054522.T2459@gamplex.bde.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200403101734.08022.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Jun Kuriyama cc: freebsd-current@FreeBSD.org Subject: Re: Expand libdisk to use 64bit size/offset X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2004 22:33:13 -0000 On Wednesday 10 March 2004 02:16 pm, Bruce Evans wrote: > On Wed, 10 Mar 2004, John Baldwin wrote: > > On Tuesday 09 March 2004 07:37 pm, Jun Kuriyama wrote: > > > I found sysinstall(8) cannot handle TB class storage. It looks > > > both of libdisk and sysinstall should be fixed. > > > > > > I'm trying to improve this situation, but I'm not sure I'm going to > > > the right direction. Please look this patch (including my debugging > > > stuff and XXX comments which should be resolved/removed). > > This will probably need EFI, since DOS partitions are limited to 2^31 > or 2^32 sectors and the sector size may be restricted to 512. > > > > http://www.imgsrc.co.jp/~kuriyama/BSD/libdisk-20040310.diff > > I didn't look closely. > > > > I choose daddr_t as larger storage for offset, size and end member of > > > "struct chunk". I think offset and end is okay, but I don't know > > > daddr_t for offset is correct or not. > > > > dadd_t is a uint32_t, so it won't help. Just use off_t for chunk > > offset/size/end. > > Erm, daddr_t is (signed) int64_t. It is the correct type for storing > counts of DEV_BSIZE'd blocks (DEV_BSIZE = 512), so it is correct for > sector counts in libdisk to the extent that libdisk is limited to > DEV_BSIZE'd sectors. Counts of blocks of other sizes should use a > different typedef. E.g., ufs uses types ufs1_daddr_t (32-bit ufs1 > block numbers), ufs2_daddr_t (64-bit ufs2 block numbers) and ufs_lbn_t > (64-bit ufs logical block numbers). Bah, I looked for u_daddr_t (which is 32-bit (why?)). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org