From owner-freebsd-current@FreeBSD.ORG Thu Mar 29 19:16:22 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 113CE16A404 for ; Thu, 29 Mar 2007 19:16:22 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-3-125.belrs4.nsw.optusnet.com.au [220.239.3.125]) by mx1.freebsd.org (Postfix) with ESMTP id 9355213C4C3 for ; Thu, 29 Mar 2007 19:16:21 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.8/8.13.8) with ESMTP id l2TJGDgN003219; Fri, 30 Mar 2007 05:16:13 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.8/8.13.8/Submit) id l2TJGDvd003218; Fri, 30 Mar 2007 05:16:13 +1000 (EST) (envelope-from peter) Date: Fri, 30 Mar 2007 05:16:13 +1000 From: Peter Jeremy To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20070329191613.GB827@turion.vk2pj.dyndns.org> References: <460AE39B.4070706@root.org> <86odmcqylx.fsf@dwp.des.no> <200703291905.00192.pieter@degoeje.nl> <86k5wzq4vx.fsf@dwp.des.no> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i9LlY+UWpKt15+FH" Content-Disposition: inline In-Reply-To: <86k5wzq4vx.fsf@dwp.des.no> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.13 (2006-08-11) Cc: current@freebsd.org, Nate Lawson Subject: Re: libfetch ftp patch for less latency X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2007 19:16:22 -0000 --i9LlY+UWpKt15+FH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-Mar-29 20:30:26 +0200, Dag-Erling Smrgrav wrote: >Libfetch used to do what Nate suggests, and it was changed to the >current behaviour because we encountered servers in the field with >which it didn't work. At first glance, the current behaviour does seem unnecessary and Nate's patch seems an "obvious" improvement. Having a comment near _ftp_cwd() explaining the current behaviour and why it isn't possible to pass a pathname to CWD would have saved Nate some effort and removed the need for this thread. Sometimes, it is as important to document why an alternative algorithm was not chosen as it is to document what the code is doing. --=20 Peter Jeremy --i9LlY+UWpKt15+FH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGDBB9/opHv/APuIcRAhS2AKDAGVeajrhKsPQ2u9uQtdhmS125TgCggJUm WlgIGnSjwOh6S1wGvklxT3g= =bfz4 -----END PGP SIGNATURE----- --i9LlY+UWpKt15+FH--