From owner-cvs-doc@FreeBSD.ORG  Thu Sep 25 08:46:03 2003
Return-Path: <owner-cvs-doc@FreeBSD.ORG>
Delivered-To: cvs-doc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C6AD816A4B3; Thu, 25 Sep 2003 08:46:03 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 33B9443F93; Thu, 25 Sep 2003 08:46:03 -0700 (PDT)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 015052ED419; Thu, 25 Sep 2003 08:46:02 -0700 (PDT)
Date: Thu, 25 Sep 2003 17:46:02 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Josef El-Rayes <j.el-rayes@daemon.li>
Message-ID: <20030925154602.GH8404@elvis.mu.org>
References: <200309251252.h8PCq7Tc093693@repoman.freebsd.org>
	<20030925152525.GA410@daemon.li>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030925152525.GA410@daemon.li>
User-Agent: Mutt/1.4.1i
cc: cvs-all@FreeBSD.org
cc: doc-committers@FreeBSD.org
cc: cvs-doc@FreeBSD.org
cc: Ken Smith <kensmith@FreeBSD.org>
Subject: Re: cvs commit:
	doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml
X-BeenThere: cvs-doc@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the doc and www trees <cvs-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-doc>
List-Post: <mailto:cvs-doc@freebsd.org>
List-Help: <mailto:cvs-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Sep 2003 15:46:04 -0000

Josef El-Rayes wrote:
> Ken Smith <kensmith@FreeBSD.org> wrote:
> > - "whitespace change" that coverts existing driver example code
> > to be style(9) compliant, matching format of new driver code
> 
> for me this is strange, i always thought that we do not do patches which
> do whitespace changes only - which does make the repository bigger
> without any real benefit.

Not really - what is most important is to not mix functional changes and
whitespace changes touching different parts of the code in a single commit
since it makes the diff much harder to read.  Bearing this in mind, when
you want a file to be style(9) compliant, you sometimes have to bite the
bullet and commit whitespace changes only.  I usually do this before
heavily modifying a file, making it style(9) compliant before doing
anything else.  This way, I'm not tempted to fix style(9) bugs when doing
functional changes and I keep the functional changes commit clean.

Cheers,
Maxime