From owner-cvs-all@FreeBSD.ORG  Sat Mar 27 08:05:56 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA467106566B;
	Sat, 27 Mar 2010 08:05:56 +0000 (UTC)
	(envelope-from beyert@fastmail.fm)
Received: from out3.smtp.messagingengine.com (out3.smtp.messagingengine.com
	[66.111.4.27]) by mx1.freebsd.org (Postfix) with ESMTP id B11D38FC1A;
	Sat, 27 Mar 2010 08:05:56 +0000 (UTC)
Received: from compute2.internal (compute2.internal [10.202.2.42])
	by gateway1.messagingengine.com (Postfix) with ESMTP id 1A454EA433;
	Sat, 27 Mar 2010 03:49:10 -0400 (EDT)
Received: from heartbeat2.messagingengine.com ([10.202.2.161])
	by compute2.internal (MEProxy); Sat, 27 Mar 2010 03:49:10 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com;
	h=date:message-id:from:to:cc:subject:in-reply-to:references:mime-version:content-type;
	s=smtpout; bh=lxAPpwElR/zWYBbu7A65prc0dI0=;
	b=S4IRUD7vMlS3ZjyRsOIlEMjKsUH7odTJPmxDN1wDbXcf1HaAZar1QbJax0XonJxsOvDeuvFlE9eEjzmYdiGQ/Ej3tjHocsMFQEtUFH7Y/55jn1N8TBFjW3ZXo1jpOpGvsKwPwm1QeCLpRdsgEaPGp2CfLMaOseAutol61h783zo=
X-Sasl-enc: EyNZzREKJOhYB3k1YAzJeaJIvz0diAmzRIVJm38+oqME 1269676149
Received: from aeonserv.aeonnet.fastmail.fm
	(cpe-76-90-217-240.socal.res.rr.com [76.90.217.240])
	by mail.messagingengine.com (Postfix) with ESMTPSA id D2B6348F27;
	Sat, 27 Mar 2010 03:49:08 -0400 (EDT)
Date: Sat, 27 Mar 2010 00:48:29 -0700
Message-ID: <877hoyqk6q.wl@fastmail.fm>
From: Timothy Beyer <beyert@fastmail.fm>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
In-Reply-To: <20100327023446.GA52463@FreeBSD.org>
References: <201003211256.o2LCur0a025048@repoman.freebsd.org>
	<20100326191544.d17a11df.stas@FreeBSD.org>
	<20100327023446.GA52463@FreeBSD.org>
User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7
	(=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.4 (patch 22)
	(Instant Classic) (i386--freebsd)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: Martin Wilke <miwi@FreeBSD.org>, beyert@cs.ucr.edu, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org, Stanislav Sedov <stas@FreeBSD.org>,
	cvs-ports@FreeBSD.org
Subject: Re: cvs commit: ports/textproc Makefile ports/textproc/htmlc
	Makefile distinfo pkg-descr
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Mar 2010 08:05:57 -0000

At Sat, 27 Mar 2010 02:34:46 +0000,
Alexey Dokuchaev wrote:
> 
> Just a couple of more comments, now that stas@ gave a diff; hope you
> don't mind Martin.
> 
> On Fri, Mar 26, 2010 at 07:15:44PM -0700, Stanislav Sedov wrote:
> > On Sun, 21 Mar 2010 12:56:53 +0000 (UTC)
> > Martin Wilke <miwi@FreeBSD.org> mentioned:
> > +MAINTAINER=    beyert@cs.ucr.edu
> > +COMMENT=       A text file generator
> 
> I'm afraid COMMENT should be augmented here; it is way too generic to
> describe a port.
> 
Point taken, I assumed that a terse description was desired, I could submit a more complete description soon.

> > +#MAN1=         htmlc.1
> 
> Any reason for this commented out statement?
> 
I didn't originally comment the man page out, I was wondering about the same thing.

> > +HAS_CONFIGURE= yes
> > +CONFIGURE_ARGS=        --prefix ${LOCALBASE}
> > 
> > This looks weird.  Is this port PREFIX safe?
> 
> In fact, passing correct --prefix is one thing of GNU_ vs. HAS_
> CONFIGURE statements.  Does this port uses autotools-generated configure
> script, by chance?  If yes, you should have dropped bogus --prefix
> assignment (entire CONFIGURE_ARGS line) and just use GNU_CONFIGURE.  If
> configure script is not autotools-generated, but accepts --prefix, it
> should probably be ${PREFIX}.  If this particular port assumes PREFIX ==
> LOCALBASE, comment should be provided stating (at best, explaining) it.

Point taken, I can fix that .
> 
> > +do-install:
> > +       @${INSTALL_PROGRAM} ${WRKSRC}/compiler/htmlc ${PREFIX}/bin
> > +       @${INSTALL_PROGRAM} ${WRKSRC}/compiler/htmlc.byt ${PREFIX}/bin
> > +       @${MKDIR} ${DATADIR}
> > +       @${INSTALL_DATA} ${WRKSRC}/config/env ${DATADIR}
> 
> INSTALL_FOO statements should not be muted.
> 
> ./danfe