From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 21 13:00:18 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E97E71065680 for ; Wed, 21 Sep 2011 13:00:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B5F598FC13 for ; Wed, 21 Sep 2011 13:00:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8LD0Hkj006526 for ; Wed, 21 Sep 2011 13:00:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8LD0Htb006525; Wed, 21 Sep 2011 13:00:17 GMT (envelope-from gnats) Resent-Date: Wed, 21 Sep 2011 13:00:17 GMT Resent-Message-Id: <201109211300.p8LD0Htb006525@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF55F1065670 for ; Wed, 21 Sep 2011 12:51:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id DF8E98FC15 for ; Wed, 21 Sep 2011 12:51:35 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8LCpZ3u003993 for ; Wed, 21 Sep 2011 12:51:35 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p8LCpZBa003992; Wed, 21 Sep 2011 12:51:35 GMT (envelope-from nobody) Message-Id: <201109211251.p8LCpZBa003992@red.freebsd.org> Date: Wed, 21 Sep 2011 12:51:35 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/160867: Swapped arguments in cap_test_capmode.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2011 13:00:19 -0000 >Number: 160867 >Category: misc >Synopsis: Swapped arguments in cap_test_capmode.c >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 21 13:00:17 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: >Organization: >Environment: >Description: Swapped arguments in cap_test_capmode.c . >How-To-Repeat: >Fix: diff -u -r1.2 cap_test_capmode.c --- tools/regression/security/cap_test/cap_test_capmode.c 4 Aug 2011 14:20:13 -0000 1.2 +++ tools/regression/security/cap_test/cap_test_capmode.c 21 Sep 2011 08:53:46 -0000 @@ -117,7 +117,7 @@ CHECK_SYSCALL_SUCCEEDS(close, fd_close); CHECK_SYSCALL_SUCCEEDS(dup, fd_file); CHECK_SYSCALL_SUCCEEDS(fstat, fd_file, &sb); - CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, SEEK_SET, 0); + CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, 0, SEEK_SET); CHECK_SYSCALL_SUCCEEDS(msync, &fd_file, 8192, MS_ASYNC); CHECK_SYSCALL_SUCCEEDS(profil, NULL, 0, 0, 0); CHECK_SYSCALL_SUCCEEDS(read, fd_file, &ch, sizeof(ch)); Patch attached with submission follows: diff -u -r1.2 cap_test_capmode.c --- tools/regression/security/cap_test/cap_test_capmode.c 4 Aug 2011 14:20:13 -0000 1.2 +++ tools/regression/security/cap_test/cap_test_capmode.c 21 Sep 2011 08:53:46 -0000 @@ -117,7 +117,7 @@ CHECK_SYSCALL_SUCCEEDS(close, fd_close); CHECK_SYSCALL_SUCCEEDS(dup, fd_file); CHECK_SYSCALL_SUCCEEDS(fstat, fd_file, &sb); - CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, SEEK_SET, 0); + CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, 0, SEEK_SET); CHECK_SYSCALL_SUCCEEDS(msync, &fd_file, 8192, MS_ASYNC); CHECK_SYSCALL_SUCCEEDS(profil, NULL, 0, 0, 0); CHECK_SYSCALL_SUCCEEDS(read, fd_file, &ch, sizeof(ch)); >Release-Note: >Audit-Trail: >Unformatted: