From owner-svn-src-head@freebsd.org Tue Oct 31 15:34:09 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 585F5E5D1BE; Tue, 31 Oct 2017 15:34:09 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DF027EBA5; Tue, 31 Oct 2017 15:34:09 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x22b.google.com with SMTP id p186so35978346ioe.12; Tue, 31 Oct 2017 08:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/xv6OsPe8RnIYcIGHIMUvUjdUPIlW5vTjObR2FGn7Qo=; b=ptbwdi/MeknZYce3228zSy2fvBK9FnVwut5PEzsHd0eNx+xh1R+fAGAohkL7REEsUB JaZwkm1fpO30N65Gw8qZIot9JirBqO/sGeUsLSJzU4hFFyXSWJMKPhGdaEaGFGJ6xU1j VqC5DOXNA3VWe3BQwzt0R7f1dE2MocgqOsyjDwBL+BUPAeQiX84eiL3zlnGBMYHfQYVs m78CTaL2L0JHi+TEwkMLcmV92IE9ahdydAi59MpmFM6JT07b5xK+9rIZePs6dCEUYl9I pA2wJqQ2FbMp1evbFCkSZjL2XWi+YntuzfnEml8E6CyFRC2qwVpvA/9xF1nbeq1ELs8m LGxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/xv6OsPe8RnIYcIGHIMUvUjdUPIlW5vTjObR2FGn7Qo=; b=RfVoBKqKe1215S8HYeeg2Q/LfPj5HiUe8tqhrpSa9frP+PfLPtEHGfLnu96E5V3RU7 ed4GOmR6BeNxhpIkUwdndmm1dAG6zlYT6nTPl7/CB/3zi+a2YwrgNLNlpnW9pltqi1GM eOpXUItS2knCmyFX33rFZ36hBG3ERm/rhfSjvAY6fqeRgi4F9m5b0POEgOFO+q0fqkDQ 5puezGeq4J9dcucm7pfaGAWIRInr0zdmQSUlaMNQhkN/l9sJ7ld1+YGjtoO+40L71PEi FtbTHcVUXf90gbKTerziF7z/a2HC6lAEcpB6wkw/54sKeIo/bgWHw9fuYMWFQGuJ88WE RAsA== X-Gm-Message-State: AMCzsaV1yWiYmCrMNWUMrLsuxKxGtlkCwgC179ca/Oqa3lGtx3k4/DQp RpNmwkF1+VvNraXWRmqhxr1/PBXzc7I+WSa0UuE= X-Google-Smtp-Source: ABhQp+QCm7ktNCMkAEQDVJPZpOZoSO9e1OePF14a8FFECDczbQlgVqjTNRUGvCpu6aSjUq+TkEPmpyp4mDwZNjffaV8= X-Received: by 10.36.22.13 with SMTP id a13mr3733341ita.69.1509464048438; Tue, 31 Oct 2017 08:34:08 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.14.208 with HTTP; Tue, 31 Oct 2017 08:33:47 -0700 (PDT) In-Reply-To: <5e94395e-9feb-0f17-db3b-43583c461242@gmail.com> References: <201710271623.v9RGNjec047721@repo.freebsd.org> <5e94395e-9feb-0f17-db3b-43583c461242@gmail.com> From: Ed Maste Date: Tue, 31 Oct 2017 11:33:47 -0400 X-Google-Sender-Auth: dripmaB94OF1XhkRZ0FpA0c-6qM Message-ID: Subject: Re: svn commit: r325042 - head/cddl/contrib/opensolaris/lib/libdtrace/common To: meloun.michal@gmail.com Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 15:34:09 -0000 On 27 October 2017 at 12:39, Michal Meloun wrote: > > On 27.10.2017 18:23, Ed Maste wrote: >> Author: emaste >> Date: Fri Oct 27 16:23:45 2017 >> New Revision: 325042 >> URL: https://svnweb.freebsd.org/changeset/base/325042 >> >> Log: >> libdtrace: replace "DOODAD" with more descriptive string >> > Imho, assert would be much more appropriate. Perhaps, or I suspect we should just return an error. I'll take a look at it later on.