From owner-freebsd-bugs@FreeBSD.ORG Fri Apr 22 16:10:09 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C64441065676 for ; Fri, 22 Apr 2011 16:10:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A1A3C8FC16 for ; Fri, 22 Apr 2011 16:10:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3MGA9gU032204 for ; Fri, 22 Apr 2011 16:10:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p3MGA9ON032202; Fri, 22 Apr 2011 16:10:09 GMT (envelope-from gnats) Resent-Date: Fri, 22 Apr 2011 16:10:09 GMT Resent-Message-Id: <201104221610.p3MGA9ON032202@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, David Wolfskill Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41A611065672 for ; Fri, 22 Apr 2011 16:08:30 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (m209-73.dsl.rawbw.com [198.144.209.73]) by mx1.freebsd.org (Postfix) with ESMTP id 1FDE48FC15 for ; Fri, 22 Apr 2011 16:08:29 +0000 (UTC) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.14.4/8.14.4) with ESMTP id p3MG8TBc042831 for ; Fri, 22 Apr 2011 09:08:29 -0700 (PDT) (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.14.4/8.14.4/Submit) id p3MG8T6k042830; Fri, 22 Apr 2011 09:08:29 -0700 (PDT) (envelope-from david) Message-Id: <201104221608.p3MG8T6k042830@albert.catwhisker.org> Date: Fri, 22 Apr 2011 09:08:29 -0700 (PDT) From: David Wolfskill To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/156579: Tweak to Makefile.in to document which kernel is installed X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: David Wolfskill List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2011 16:10:09 -0000 >Number: 156579 >Category: kern >Synopsis: Tweak to Makefile.in to document which kernel is installed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Apr 22 16:10:09 UTC 2011 >Closed-Date: >Last-Modified: >Originator: David Wolfskill >Release: FreeBSD 9.0-CURRENT i386 >Organization: Wolfskill & Dowlng Residence >Environment: System: FreeBSD g1-222.catwhisker.org. 9.0-CURRENT FreeBSD 9.0-CURRENT #208 r220945: Fri Apr 22 05:26:37 PDT 2011 root@g1-220.catwhisker.org.:/usr/obj/usr/src/sys/CANARY i386 >Description: Performing "make kernel" (or "make buildkernel installkernel") causes various "progress messages" to be logged at certain "milestone" events in the course of the build/install. Some of them mention (for example) which kernel configuration file is being used for the kernel build, e.g.: >>> Kernel build for CANARY started on Fri Apr 22 05:16:35 PDT 2011 ... >>> Kernel build for CANARY completed on Fri Apr 22 05:38:52 PDT 2011 This is sometimes useful, and at worst, nearly harmless. The corresponding message for the installation of the kernel, however, merely reads: >>> Installing kernel While that's better than nothing, and it's actually quite adequate for machines that build a single kernel image, for machines that are used to build other kernels, or for their "clients" -- machines that install kernels that they don't build -- I believe it would be a bit more useful to augment the above to read (e.g.): >>> Installing kernel CANARY (This could be augmented with a time stamp and/or the name of the directory in /boot where it is being installed, but I see those as not quite as important -- so I've restricted the scope of this PR.) >How-To-Repeat: Build & install some kernels. Here are some excerpts from my build machine: >>> Kernel build for GENERIC started on Fri Apr 22 04:17:35 PDT 2011 >>> Kernel build for GENERIC completed on Fri Apr 22 04:19:46 PDT 2011 >>> Kernel build for ALBERT started on Fri Apr 22 04:19:46 PDT 2011 >>> Kernel build for ALBERT completed on Fri Apr 22 04:21:45 PDT 2011 >>> Kernel build for JANUS started on Fri Apr 22 04:21:45 PDT 2011 >>> Kernel build for JANUS completed on Fri Apr 22 04:23:40 PDT 2011 >>> Installing kernel And here's a corresponding excerpt from one of its clients: >>> Installing kernel And from the other of its clients: >>> Installing kernel I think that augmenting the "Installing kernel" to mention which kernel config was being installed on which machine might be useful for other folks, not just me. :-} >Fix: For the request being made: Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 220945) +++ Makefile.inc1 (working copy) @@ -868,7 +868,7 @@ false .endif @echo "--------------------------------------------------------------" - @echo ">>> Installing kernel" + @echo ">>> Installing kernel ${KERNCONF}" @echo "--------------------------------------------------------------" cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \ ${CROSSENV} PATH=${TMPPATH} \ For a rather more elaborate approach Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 220945) +++ Makefile.inc1 (working copy) @@ -868,7 +868,7 @@ false .endif @echo "--------------------------------------------------------------" - @echo ">>> Installing kernel" + @echo ">>> Installing kernel ${KERNCONF} as ${INSTALLKERNEL} on `LC_ALL=C date`" @echo "--------------------------------------------------------------" cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \ ${CROSSENV} PATH=${TMPPATH} \ >Release-Note: >Audit-Trail: >Unformatted: