From owner-freebsd-current@freebsd.org Tue Nov 20 06:45:06 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE4C011023FA for ; Tue, 20 Nov 2018 06:45:06 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 000717CB57 for ; Tue, 20 Nov 2018 06:45:05 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd44.google.com with SMTP id u19so613744ioc.2 for ; Mon, 19 Nov 2018 22:45:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mp6YbDhoc9+HpvRJlFVkS5baHQann4F17McNbj0VTiM=; b=abRwtez2lamKvYOe0LzHTkrHONsaWVnSkC664xQWMcdASawTYZmIC4bg+b9Jsve6mY dwBL+T1jmCEh3QAv/ih8gZYyNKKno4/dWtiAn5zsuxklkgdZrKKIgGV1XsQhwDNJrBpZ Ibe1osYN+cH/sqJSum4CZDevET4+s0mYfbqdkC/ZChsJcW6fRhQ5mpaAe6PGALnUdHcG Q6h+25j5mVZfzRtK/fLdwuUVObUnwNUlqWgFoAyuIvaG6VK4AEowdkQ3gloMdd4vGN8H V/qeXP+AhzpYPBl1BN9IGpH0siPGOXoDakkZnHOlb3yVGoV4/562RdTDCUACtj8mDUy6 ZvSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mp6YbDhoc9+HpvRJlFVkS5baHQann4F17McNbj0VTiM=; b=hopgHJcsrRCZgyHwU/mGd2nZaqso/BT8l/EVECaVKCwrtbeDDGGvL5leJCmsGJ4Add oFZaq44VJzvp9oTjGRkJHgpir+rYVA5PpcUrV0u4MyYZj+zxVUfUTbKwlDw/lNzneU0M +9cni9e5azfWvcSwsZhGyTImIJVKby2FJ+q06E9vGjXnK/+Lx706M2lzPaKUNepgxSNo PLCewi/jbfq0NWqLlRup1ZX0N6tKyw6eOmE5K0WpOQ0HMK09BZg5/XAfQm4BsNWAMz/I nQssU8aMJwV9nJuafmxWDiib0Zo+E50w0ade6YFvTUefRGYfwMDjXy8fzD8OD661iNU1 Zmeg== X-Gm-Message-State: AA+aEWbtjXynGewaVXDhgjDR0DJoHa2ih3AeVMyTpxtMScGtfQL7z73J oKlVReGGXFqDV+ZZ59HCfz8= X-Google-Smtp-Source: AFSGD/XOsUfpmAi3cslqITFIsWk5kTFl31cnD+mAYZn+3ISVpTH2WA57O1OrHgYcEoSAdjLysIMqhg== X-Received: by 2002:a5e:c64a:: with SMTP id s10mr608396ioo.284.1542696305236; Mon, 19 Nov 2018 22:45:05 -0800 (PST) Received: from raichu (toroon0560w-lp130-07-64-229-95-98.dsl.bell.ca. [64.229.95.98]) by smtp.gmail.com with ESMTPSA id q23sm4993187ioi.66.2018.11.19.22.45.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 22:45:04 -0800 (PST) Sender: Mark Johnston Date: Tue, 20 Nov 2018 01:45:00 -0500 From: Mark Johnston To: Sylvain GALLIANO Cc: freebsd-current@freebsd.org Subject: Re: Panic on kern_event.c Message-ID: <20181120064500.GA2371@raichu> References: <20181107043503.GB30861@raichu> <20181115221019.GA2514@raichu> <20181116154210.GB17379@raichu> <20181118003554.GC2799@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 000717CB57 X-Spamd-Result: default: False [-3.29 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.92)[-0.918,0]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; IP_SCORE(-0.66)[ip: (0.87), ipnet: 2607:f8b0::/32(-2.44), asn: 15169(-1.65), country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 06:45:06 -0000 On Mon, Nov 19, 2018 at 10:26:51AM +0100, Sylvain GALLIANO wrote: > With this latest patch, after stressing syslog-ng few minutes, it do not > log anymore and a simple kill do not work (I have to do kill -9) Thanks for your patience. I finally managed to reproduce the problem and can see the bug now. Please try this patch instead. diff --git a/sys/kern/kern_event.c b/sys/kern/kern_event.c index d9c670e29d60..0be765a040ed 100644 --- a/sys/kern/kern_event.c +++ b/sys/kern/kern_event.c @@ -1538,6 +1538,10 @@ kqueue_register(struct kqueue *kq, struct kevent *kev, struct thread *td, int wa kn_enter_flux(kn); error = knote_attach(kn, kq); + if ((kev->flags & EV_ENABLE) != 0) + kn->kn_status &= ~KN_DISABLED; + else if ((kev->flags & EV_DISABLE) != 0) + kn->kn_status |= KN_DISABLED; KQ_UNLOCK(kq); if (error != 0) { tkn = kn; @@ -1570,6 +1574,11 @@ kqueue_register(struct kqueue *kq, struct kevent *kev, struct thread *td, int wa KNOTE_ACTIVATE(kn, 1); } + if ((kev->flags & EV_ENABLE) != 0) + kn->kn_status &= ~KN_DISABLED; + else if ((kev->flags & EV_DISABLE) != 0) + kn->kn_status |= KN_DISABLED; + /* * The user may change some filter values after the initial EV_ADD, * but doing so will not reset any filter which has already been @@ -1595,11 +1604,9 @@ kqueue_register(struct kqueue *kq, struct kevent *kev, struct thread *td, int wa * kn_knlist. */ done_ev_add: - if ((kev->flags & EV_ENABLE) != 0) - kn->kn_status &= ~KN_DISABLED; - else if ((kev->flags & EV_DISABLE) != 0) - kn->kn_status |= KN_DISABLED; - + /* + * KN_DISABLED will be stable while the knote is in flux. + */ if ((kn->kn_status & KN_DISABLED) == 0) event = kn->kn_fop->f_event(kn, 0); else @@ -1861,6 +1868,8 @@ kqueue_scan(struct kqueue *kq, int maxevents, struct kevent_copyops *k_ops, } TAILQ_REMOVE(&kq->kq_head, kn, kn_tqe); + KASSERT(kn == marker || (kn->kn_status & KN_QUEUED) != 0, + ("knote %p not queued", kn)); if ((kn->kn_status & KN_DISABLED) == KN_DISABLED) { kn->kn_status &= ~KN_QUEUED; kq->kq_count--;