From owner-freebsd-bugs@FreeBSD.ORG  Wed Nov  4 12:10:04 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0ECEF106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  4 Nov 2009 12:10:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id F16DA8FC20
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  4 Nov 2009 12:10:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nA4CA3xi055480
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 4 Nov 2009 12:10:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nA4CA3XH055479;
	Wed, 4 Nov 2009 12:10:03 GMT (envelope-from gnats)
Date: Wed, 4 Nov 2009 12:10:03 GMT
Message-Id: <200911041210.nA4CA3XH055479@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Tomokazu HARADA <tharada@oucrc.org>
Cc: 
Subject: Re: kern/140251: [ata] [patch] add UDMA5 support to Intel SCH
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Tomokazu HARADA <tharada@oucrc.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Nov 2009 12:10:04 -0000

The following reply was made to PR kern/140251; it has been noted by GNATS.

From: Tomokazu HARADA <tharada@oucrc.org>
To: bug-followup@FreeBSD.org
Cc: tharada@oucrc.org
Subject: Re: kern/140251: [ata] [patch] add UDMA5 support to Intel SCH
Date: Wed, 04 Nov 2009 20:39:29 +0900 (JST)

 Previous patch is broken. Needs additional patch
 
 --- ata-intel.c-	2009-11-04 00:38:25.000000000 +0900
 +++ ata-intel.c	2009-11-04 20:36:01.000000000 +0900
 @@ -394,14 +394,17 @@
      if (!error) {
  	if (mode >= ATA_UDMA0) {
  	    tim |= (0x1 << 31);
 +	    tim &= ~(0x7 << 16);
  	    tim |= ((mode & ATA_MODE_MASK) << 16);
  	}
  	else if (mode >= ATA_WDMA0) {
  	    tim &= ~(0x1 << 31);
 +	    tim &= ~(0x3 << 8);
  	    tim |= ((mode & ATA_MODE_MASK) << 8);
  	}
  	else if (mode >= ATA_PIO0) {
 -	    tim |= (mode - ATA_PIO0);
 +	    tim &= ~(0x7);
 +	    tim |= (mode & 0x7);
  	}
  
  	pci_write_config(gparent, dtim, tim, 4);
 
 -----
 Tomokazu HARADA