From owner-freebsd-stable@FreeBSD.ORG  Mon Jul 12 09:55:19 2010
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B1DC91065679
	for <freebsd-stable@freebsd.org>; Mon, 12 Jul 2010 09:55:19 +0000 (UTC)
	(envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id BA80D8FC23
	for <freebsd-stable@freebsd.org>; Mon, 12 Jul 2010 09:55:18 +0000 (UTC)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA16845;
	Mon, 12 Jul 2010 12:55:11 +0300 (EEST)
	(envelope-from avg@icyb.net.ua)
Received: from localhost.topspin.kiev.ua ([127.0.0.1])
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1OYFjC-000Gkv-Pq; Mon, 12 Jul 2010 12:55:10 +0300
Message-ID: <4C3AE67D.9050401@icyb.net.ua>
Date: Mon, 12 Jul 2010 12:55:09 +0300
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.24 (X11/20100603)
MIME-Version: 1.0
To: Peter Jeremy <peterjeremy@acm.org>
References: <20100711182511.GA21063@soda.CSUA.Berkeley.EDU>	<20100712093818.GA27693@server.vk2pj.dyndns.org>
	<20100712093933.GA27950@server.vk2pj.dyndns.org>
In-Reply-To: <20100712093933.GA27950@server.vk2pj.dyndns.org>
X-Enigmail-Version: 0.96.0
Content-Type: text/plain; charset=KOI8-U
Content-Transfer-Encoding: 7bit
Cc: freebsd-stable@freebsd.org, Richard Lee <ricky@csua.berkeley.edu>
Subject: Re: Serious zfs slowdown when mixed with another file system
	(ufs/msdosfs/etc.).
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jul 2010 09:55:19 -0000

on 12/07/2010 12:39 Peter Jeremy said the following:
>  /*
> - * If pages are needed or we're within 2048 pages
> - * of needing to page need to reclaim
> + * If we're within 2048 pages of pagedaemon start, reclaim...
>   */
> - if (vm_pages_needed || (vm_paging_target() > -2048))
> + if (vm_pages_needed && (vm_paging_target() > -2048))

I am not sure that what comment says is actually what the code checks.
For both pre-patch and post-patch versions.

-- 
Andriy Gapon