From nobody Wed Oct 8 19:14:14 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4chjNl0F2Xz6BHfF; Wed, 08 Oct 2025 19:14:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4chjNk6Rddz3cQp; Wed, 08 Oct 2025 19:14:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759950854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JtnL2Tw6LjndLNYamdwpd0Awizv+RsJn9mI/oKzj/0g=; b=xoG9fX2SCh0g0AQFXyuWD3wyGBJAcR2VPntEH+ozmPL6CkOzRUqxS63W3KCAmm+Dshg7Bk 1GMRWt+4NcnI11d3G7S19S9bhmcJrbisU8jGMh7tOrJNgFlkv0hXd0aWnPnkBShgAidcf+ r1If12cGTnZ+jowIk4+X9zy6ICOCLVNR2KLuSIOB7iG+Urxrs3n0CMBiA3MWae+svx4Zvr HkbgdagOqHhEWAiyw/22MC/Zw/+FjIQNb6L4o64VYRFbDm1eh7CurS8/WBHItAHVRnYQvF kpWkuWsvZHKCxSbWLAI9QXPDCpjdPdonV0gz4qNHxs0kJecuz8Y7mQWcf7/f4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759950854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JtnL2Tw6LjndLNYamdwpd0Awizv+RsJn9mI/oKzj/0g=; b=u27tTXb+5GU3RehSxY7L1ynCHebq+iRcznwqbBdf23RBJZlfluJeKoUapi/u4vryiP7J2L FCFA+jxr5wKwtBHVegvZfQpaT1KuOxLvvaut48QG8Uh6W0mCjYXuEu/wMrQ18tXqMPDIl2 WCbt7XHnAy14+NnrOzKaXjilQxZ6S6pQFE/Z4pbRyRNCFW3ImQJTZCxO7r7Mm3GSrPXiKl mVTZZcf2XB5+pW5b8L0H5SBEIi3Gl02RweDnBgI3qgwZI9XTrfzpIPhaBRliY30Ah9lC4O RLseevWhEWQJNvnvXSOnyW1pDCGSQRz357+RstXElzYM1GvDoDP7Es8kX8ww5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759950854; a=rsa-sha256; cv=none; b=Jpz9z3faRqUr0tyxEwkkyS8k2hK7hlrXO6v42vzI5E8LKo49LWmrepiLQbXjDzmkI+clsH i7c91cGCwcFWvr+3VexB+oFol1zE96bIKzmRKjkTKdpCEyGdQjbuMoMj+XoVzm/6CsQk9y 3BXU4zMgHj+965XVGJw0unYOocyfWsXMC3UdpHHIXevf6er64TSfZ54u7FKn6DLSkBpxyI 4Z6SbMZ/fH6aQBxVWhfIF202yJdIT7YHVJNe5/bewUUHFzcP80qy+M16OJl4WSHHKYzSKl 23RWjQmDSHBvZEmOD8Tw41+mHg1aJgXRh33dpDhOjGFjDZmp0nokduzlHTmBgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4chjNk5yxTzl4n; Wed, 08 Oct 2025 19:14:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 598JEEDa010710; Wed, 8 Oct 2025 19:14:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 598JEEcJ010707; Wed, 8 Oct 2025 19:14:14 GMT (envelope-from git) Date: Wed, 8 Oct 2025 19:14:14 GMT Message-Id: <202510081914.598JEEcJ010707@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Jonathan T. Looney" Subject: git: 55c28005f544 - main - x86: support sending non-fatal MCA messages to syslog List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jtl X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 55c28005f544282b984ae0e15dacd0c108d8ab12 Auto-Submitted: auto-generated The branch main has been updated by jtl: URL: https://cgit.FreeBSD.org/src/commit/?id=55c28005f544282b984ae0e15dacd0c108d8ab12 commit 55c28005f544282b984ae0e15dacd0c108d8ab12 Author: Jonathan T. Looney AuthorDate: 2025-10-07 12:58:05 +0000 Commit: Jonathan T. Looney CommitDate: 2025-10-08 19:12:35 +0000 x86: support sending non-fatal MCA messages to syslog Currently, all MCA messages are logged to the console. However, this can have performance implications which can turn a storm of correctable errors into a disruptive event. Provide an option to direct non-fatal messages to syslog. Note that we will always log to the console for fatal errors. Reviewed by: markj MFC after: 2 weeks Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D12278 --- sys/x86/x86/mca.c | 43 ++++++++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c index a167854e8bbb..735efe307215 100644 --- a/sys/x86/x86/mca.c +++ b/sys/x86/x86/mca.c @@ -50,6 +50,7 @@ #include #include #include +#include #include #include #include @@ -136,6 +137,11 @@ SYSCTL_INT(_hw_mca, OID_AUTO, fake_bank, CTLFLAG_RW, "Bank to use for artificial MCAs (testing purpose only)"); #endif +static bool mca_uselog = false; +SYSCTL_BOOL(_hw_mca, OID_AUTO, uselog, CTLFLAG_RWTUN, &mca_uselog, 0, + "Should the system send non-fatal machine check errors to the log " + "(instead of the console)?"); + static STAILQ_HEAD(, mca_internal) mca_freelist; static int mca_freecount; static STAILQ_HEAD(, mca_internal) mca_records; @@ -477,7 +483,7 @@ mca_mute(const struct mca_record *rec) /* Dump details about a single machine check. */ static void -mca_log(enum scan_mode mode, const struct mca_record *rec) +mca_log(enum scan_mode mode, const struct mca_record *rec, bool fatal) { int error, numskipped; uint16_t mca_error; @@ -711,7 +717,8 @@ mca_log(enum scan_mode mode, const struct mca_record *rec) event_type)); event_type = MCA_T_UNKNOWN; } - if (!uncor) { + numskipped = 0; + if (!fatal && !uncor) { /* * Update statistics and check the rate limit for * correctable errors. The rate limit is only applied @@ -732,17 +739,31 @@ mca_log(enum scan_mode mode, const struct mca_record *rec) numskipped = mca_log_skipped; mca_log_skipped = 0; mtx_unlock_spin(&mca_lock); + } + + error = sbuf_finish(&sb); + if (fatal || !mca_uselog) { if (numskipped > 0) printf("MCA: %d events skipped due to rate limit\n", numskipped); + if (error) + printf("MCA: error logging message (sbuf error %d)\n", + error); + else + sbuf_putbuf(&sb); + } else { + if (numskipped > 0) + log(LOG_ERR, + "MCA: %d events skipped due to rate limit\n", + numskipped); + if (error) + log(LOG_ERR, + "MCA: error logging message (sbuf error %d)\n", + error); + else + log(uncor ? LOG_CRIT : LOG_ERR, "%s", sbuf_data(&sb)); } - error = sbuf_finish(&sb); - if (error) - printf("MCA: error logging message (sbuf error %d)\n", error); - else - sbuf_putbuf(&sb); - done: sbuf_delete(&sb); if (using_shared_buf) @@ -907,7 +928,7 @@ mca_record_entry(enum scan_mode mode, const struct mca_record *record) if (rec == NULL) { mtx_unlock_spin(&mca_lock); printf("MCA: Unable to allocate space for an event.\n"); - mca_log(mode, record); + mca_log(mode, record, false); return; } STAILQ_REMOVE_HEAD(&mca_freelist, link); @@ -1064,7 +1085,7 @@ mca_scan(enum scan_mode mode, bool *recoverablep) if (*recoverablep) mca_record_entry(mode, &rec); else - mca_log(mode, &rec); + mca_log(mode, &rec, true); } #ifdef DEV_APIC @@ -1148,7 +1169,7 @@ mca_process_records(enum scan_mode mode) mtx_unlock_spin(&mca_lock); STAILQ_FOREACH(mca, &tmplist, link) - mca_log(mode, &mca->rec); + mca_log(mode, &mca->rec, false); mtx_lock_spin(&mca_lock); while ((mca = STAILQ_FIRST(&tmplist)) != NULL) {