From owner-freebsd-bugs@FreeBSD.ORG Tue Feb 16 19:05:37 2010 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B138B106568F for ; Tue, 16 Feb 2010 19:05:37 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-pz0-f179.google.com (mail-pz0-f179.google.com [209.85.222.179]) by mx1.freebsd.org (Postfix) with ESMTP id 84EA08FC16 for ; Tue, 16 Feb 2010 19:05:37 +0000 (UTC) Received: by pzk9 with SMTP id 9so4725509pzk.28 for ; Tue, 16 Feb 2010 11:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=i0uu4WPkowFGsr97mwITVFdSmQDAtDNxRqkNUG5e5FE=; b=tpxd0T0HfqfCic/lInu91b5+T5cuOFqvLNbq0uvBGz5XcdJcRhsxXEVcDlLcjhM2I/ Pv96w8ivnxxxWS4C/MDfiAQxAOKS25TlDPeNG3OhTnICO7qL6JI0SnQqRO1a+nOt0vOW /6S7H1xhbv3HBARR82u7Cuj6AfMnC+6T9DFO8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=OQ7zbfcY7Qk0HEkhK8nfOVeIjUOxlMPMZH+QVtGO8dvO116lMCfaYaJ+HTIXg7yT9j xuYzSO+Gy8vxg7eWzE2/4LfMXlEwwBg1UFUqIkVFHHQtdPhZFWikBlGL4dAAygy/ebOl yB9y254ZseZN9w2AI9jEFWYm/b3IBvItXQpHM= MIME-Version: 1.0 Received: by 10.142.59.21 with SMTP id h21mr4614067wfa.182.1266347137095; Tue, 16 Feb 2010 11:05:37 -0800 (PST) In-Reply-To: <201002161710.o1GHA3GY068818@freefall.freebsd.org> References: <201002161710.o1GHA3GY068818@freefall.freebsd.org> Date: Tue, 16 Feb 2010 11:05:37 -0800 Message-ID: <7d6fde3d1002161105m2842eda9rdbb6f04932dd1c64@mail.gmail.com> From: Garrett Cooper To: Pete French Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-bugs@freebsd.org Subject: Re: bin/131861: [patch] mail(1) misses addresses when replying to all X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:05:37 -0000 On Tue, Feb 16, 2010 at 9:10 AM, Pete French wrote: > The following reply was made to PR bin/131861; it has been noted by GNATS= . > > From: Pete French > To: bug-followup@FreeBSD.org > Cc: > Subject: Re: bin/131861: [patch] mail(1) misses addresses when replying t= o all > Date: Tue, 16 Feb 2010 17:05:23 +0000 > > =A0Looks like my last email messed up the formatting of the patch. here i= t is > =A0with the tabs hopefully properly preserved! > > =A0--- usr.bin/mail/util.c.orig =A0 2010-02-02 14:10:34.220987358 +0000 > =A0+++ usr.bin/mail/util.c =A0 =A0 =A0 =A02010-02-16 09:31:08.924384302 += 0000 > =A0@@ -496,10 +496,10 @@ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*cp2++ =3D= ' '; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*cp2++ =3D c; > =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (c =3D=3D ',' && *cp = =3D=3D ' ' && !gotlt) { > =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (c =3D=3D ',' && (*cp = =3D=3D ' ' || *cp =3D=3D '"') && !gotlt) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*cp2++ =3D= ' '; > =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0while (*+= +cp =3D=3D ' ') > =A0- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0; > =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0while (*c= p =3D=3D ' ') > =A0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0cp++; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0lastsp =3D= 0; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0bufend =3D= cp2; Two dumb questions: 1. Why isn't this checking for '\0'? 2. If there's a `"', shouldn't there be a terminating the end `"' as well? It's a pretty blatant shell syntax error if that requirement isn't met... Thanks, -Garrett