From owner-cvs-src-old@FreeBSD.ORG Thu Jun 25 21:04:46 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 088E31065686 for ; Thu, 25 Jun 2009 21:04:46 +0000 (UTC) (envelope-from snb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E9D9E8FC19 for ; Thu, 25 Jun 2009 21:04:45 +0000 (UTC) (envelope-from snb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n5PL4jcc090387 for ; Thu, 25 Jun 2009 21:04:45 GMT (envelope-from snb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n5PL4jnF090386 for cvs-src-old@freebsd.org; Thu, 25 Jun 2009 21:04:45 GMT (envelope-from snb@repoman.freebsd.org) Message-Id: <200906252104.n5PL4jnF090386@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to snb@repoman.freebsd.org using -f From: Sean Nicholas Barkas Date: Thu, 25 Jun 2009 20:40:13 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ufs ufs_dirhash.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2009 21:04:46 -0000 snb 2009-06-25 20:40:13 UTC FreeBSD src repository Modified files: sys/ufs/ufs ufs_dirhash.c Log: SVN rev 195003 on 2009-06-25 20:40:13Z by snb Fix a bug reported by pho@ where one can induce a panic by decreasing vfs.ufs.dirhash_maxmem below the current amount of memory used by dirhash. When ufsdirhash_build() is called with the memory in use greater than dirhash_maxmem, it attempts to free up memory by calling ufsdirhash_recycle(). If successful in freeing enough memory, ufsdirhash_recycle() leaves the dirhash list locked. But at this point in ufsdirhash_build(), the list is not explicitly unlocked after the call(s) to ufsdirhash_recycle(). When we next attempt to lock the dirhash list, we will get a "panic: _mtx_lock_sleep: recursed on non-recursive mutex dirhash list". Tested by: pho Approved by: dwmalone (mentor) MFC after: 3 weeks Revision Changes Path 1.33 +4 -1 src/sys/ufs/ufs/ufs_dirhash.c