From owner-freebsd-commit Tue Aug 8 05:36:41 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id FAA26690 for commit-outgoing; Tue, 8 Aug 1995 05:36:41 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id FAA26605 for cvs-sys-outgoing; Tue, 8 Aug 1995 05:35:17 -0700 Received: from time.cdrom.com (time.cdrom.com [192.216.222.226]) by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id FAA26599 ; Tue, 8 Aug 1995 05:35:08 -0700 Received: from localhost (localhost [127.0.0.1]) by time.cdrom.com (8.6.11/8.6.9) with SMTP id FAA19408; Tue, 8 Aug 1995 05:34:28 -0700 To: Bruce Evans cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com, dyson@freefall.cdrom.com Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Tue, 08 Aug 1995 21:22:21 +1000." <199508081122.VAA04961@godzilla.zeta.org.au> Date: Tue, 08 Aug 1995 05:34:28 -0700 Message-ID: <19405.807885268@time.cdrom.com> From: "Jordan K. Hubbard" Sender: commit-owner@FreeBSD.org Precedence: bulk > Actually it isn't really OK to simply substitute M_NOWAIT with M_WAITOK. > If one of the malloc()s in scioctl() sleeps, then another process may > run and use the half-allocated resources. If one of the malloc()s in in > scioctl() or scopen() sleeps, then another process may run and repeat the > ioctl and (at best) allocate the resources twice. Argh. Perhaps I was too hasty. If John decides to rearchitect this, I'll pull it out of 2.1 Jordan