From owner-freebsd-bugs Sat Sep 7 12:31:24 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D3BBD37B400; Sat, 7 Sep 2002 12:31:22 -0700 (PDT) Received: from smtp3.vol.cz (smtp3.vol.cz [195.250.128.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id C0C3743E42; Sat, 7 Sep 2002 12:31:21 -0700 (PDT) (envelope-from dan@obluda.cz) Received: from obluda.cz (xkulesh.vol.cz [195.250.154.106]) by smtp3.vol.cz (8.12.5/8.12.5) with ESMTP id g87JVIBo026587; Sat, 7 Sep 2002 21:31:19 +0200 (CEST) (envelope-from dan@obluda.cz) Message-ID: <3D7A5400.1010002@obluda.cz> Date: Sat, 07 Sep 2002 21:31:12 +0200 From: Dan Lukes User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826 X-Accept-Language: cs, sk, en MIME-Version: 1.0 To: "Bruce A. Mah" Cc: freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/42384: MDXFileChunk may return 0 instead of hash References: <200209071611.g87GBolU030973@freefall.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Bruce A. Mah wrote: > Synopsis: MDXFileChunk may return 0 instead of hash > > The fix I committed > in rev. 1.17 of mdXhl.c is more straightforward; it just initializes > i before first use. Yes, your patch works, but ... With full respect to fact you are commiter, so final decision is your suverenity - can you think about revoking your's straightforward fix a commiting my (more performance friendly) one ? I still think that unecesarry initializing of [i] is waste of resources ... Thanks. Dan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message