From owner-freebsd-stable@FreeBSD.ORG Sat Feb 11 00:53:19 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C01F16A420 for ; Sat, 11 Feb 2006 00:53:19 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20EC343D76 for ; Sat, 11 Feb 2006 00:53:04 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 071501A3C2C; Fri, 10 Feb 2006 16:53:04 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 13AC9521FC; Fri, 10 Feb 2006 19:53:03 -0500 (EST) Date: Fri, 10 Feb 2006 19:53:02 -0500 From: Kris Kennaway To: Conrad Sabatier Message-ID: <20060211005302.GA73491@xor.obsecurity.org> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: freebsd-stable@freebsd.org Subject: Re: CFLAGS in libc_r, libpthread and libthr, and MUTEX stuff in kern_mutex.c X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Feb 2006 00:53:19 -0000 --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 10, 2006 at 05:00:18PM -0600, Conrad Sabatier wrote: > Given that STABLE is supposed to be...well...*stable* :-) ... >=20 > Could we possibly remove "-D_PTHREADS_INVARIANTS", "-D_LOCK_DEBUG" and "-= g" > from the CFLAGS in the Makefiles for libc_r, libpthread and libthr? I've > been under the impression that these options were only intended for > testing/debugging under CURRENT. I think your impressions are wrong. For example, -g has no effect on the installed code (since it's stripped), and IIRC -D_PTHREADS_INVARIANTS doesn't have a run-time penalty either. > On a related note, I was rather surprised to discover recently that in > sys/kern/kern_mutex.c, the MUTEX_WAKE_ALL option is forcibly defined if n= ot > already defined in the user's kernel config. While the accompanying > comment (in mutex.c) would seem to indicate that there's good reason for > doing so at this time, at the very least, this should be documented in > sys/conf/NOTES as well. > =20 > Additionally, it should also be made unmistakably clear that certain other > mutex-related options -- namely, ADAPTIVE_GIANT and NO_ADAPTIVE_MUTEXES -- > have absolutely no effect whatsoever unless SMP is also defined. While I > suppose this might be inferred from the fact that they're listed under the > SMP section of NOTES, nonetheless, there is a chance that this relationsh= ip > may go unrecognized. Sounds like you can submit a patch for these. Kris --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD7TVuWry0BWjoQKURAiOPAKDhFIjvVISseTCRsmiFJyQ+lRKoJwCdHd21 KOJNOjLmzssrjxlsz5tJhuI= =O3pp -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--