From owner-svn-src-all@FreeBSD.ORG  Tue Jan 10 09:38:31 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 65E141065673;
	Tue, 10 Jan 2012 09:38:31 +0000 (UTC) (envelope-from dim@FreeBSD.org)
Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net
	[IPv6:2001:7b8:2ff:146::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 240AE8FC16;
	Tue, 10 Jan 2012 09:38:31 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7:0:c412:ce36:3c98:43b8] (unknown
	[IPv6:2001:7b8:3a7:0:c412:ce36:3c98:43b8])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id 58FD05C37;
	Tue, 10 Jan 2012 10:38:30 +0100 (CET)
Message-ID: <4F0C0714.6060501@FreeBSD.org>
Date: Tue, 10 Jan 2012 10:38:28 +0100
From: Dimitry Andric <dim@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
	rv:10.0) Gecko/20120106 Thunderbird/10.0
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <201201100258.q0A2wT7E079753@svn.freebsd.org>
	<20120110082106.GD1801@garage.freebsd.pl>
In-Reply-To: <20120110082106.GD1801@garage.freebsd.pl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org>
Subject: Re: svn commit: r229908 - head/usr.bin/brandelf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jan 2012 09:38:31 -0000

On 2012-01-10 09:21, Pawel Jakub Dawidek wrote:
> On Tue, Jan 10, 2012 at 02:58:29AM +0000, Eitan Adler wrote:
>> Author: eadler (ports committer)
>> Date: Tue Jan 10 02:58:29 2012
>> New Revision: 229908
>> URL: http://svn.freebsd.org/changeset/base/229908
>>
>> Log:
>>    Fix warning when compiling with gcc46:
>>    	 error: variable 'verbose' set but not use
>
> Maybe we should remove -v from the manual page as well or document as no-op?
> I'd still leave it in the code though, so there is no POLA violation.

It has been a no-op since the beginning of brandelf, and I have really
no idea what the original author intended the verbose output to be. :)

It is probably best to document it as a no-op now, to reduce possible
confusion.