From owner-cvs-ports@FreeBSD.ORG  Tue Jul  5 14:13:34 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 10EEF106566C; Tue,  5 Jul 2011 14:13:34 +0000 (UTC)
Date: Tue, 5 Jul 2011 14:13:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Martin Wilke <miwi@FreeBSD.org>
Message-ID: <20110705141333.GA23300@FreeBSD.org>
References: <201106271435.p5REZYab035297@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201106271435.p5REZYab035297@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel Makefile ports/devel/libestr Makefile
	distinfo pkg-descr pkg-plist ports/devel/libestr/files
	patch-Makefile.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2011 14:13:34 -0000

On Mon, Jun 27, 2011 at 02:35:34PM +0000, Martin Wilke wrote:
> miwi        2011-06-27 14:35:34 UTC
> 
>   Modified files:
>     devel                Makefile 
>   Added files:
>     devel/libestr        Makefile distinfo pkg-descr pkg-plist 
>     devel/libestr/files  patch-Makefile.in 
>   Log:
>   A library for some string essentials.

This description (= pkg-descr) is very short and uninformative.  Also, the
port has other issues:

- Does pgollucci@ know and approve that he's listed as maintainer?
- Bogus CONFIGURE_ARGS indentation; also --prefix="${PREFIX}" is redundant
  since GNU_CONFIGURE is used
- Tab instead of space after WWW: line in pkg-descr

./danfe