From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Nov  8 10:59:15 2007
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9157416A418
	for <freebsd-ports-bugs@FreeBSD.org>;
	Thu,  8 Nov 2007 10:59:15 +0000 (UTC) (envelope-from tobez@tobez.org)
Received: from heechee.tobez.org (heechee.tobez.org [194.255.56.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4413013C4B5
	for <freebsd-ports-bugs@FreeBSD.org>;
	Thu,  8 Nov 2007 10:59:15 +0000 (UTC) (envelope-from tobez@tobez.org)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id 488B312545A; Thu,  8 Nov 2007 11:40:51 +0100 (CET)
Date: Thu, 8 Nov 2007 11:40:51 +0100
From: Anton Berezin <tobez@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Message-ID: <20071108104051.GC33233@heechee.tobez.org>
Mail-Followup-To: Anton Berezin <tobez@FreeBSD.org>,
	FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
References: <20071108094255.ED13C12542E@heechee.tobez.org>
	<200711081000.lA8A07aF008228@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200711081000.lA8A07aF008228@freefall.freebsd.org>
X-Powered-By: FreeBSD http://www.freebsd.org/
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: 
Subject: Re: ports/117916: Mk/bsd.port.mk: Reversed condition for setting
	--no-same-owner in extract
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Nov 2007 10:59:15 -0000

I would like to add that fixing this will probably make unnecessary code in
do-extract that does chmod/chown after extracting:

--- bsd.port.mk.orig2	2007-11-08 11:38:11.000000000 +0100
+++ bsd.port.mk	2007-11-08 11:38:17.000000000 +0100
@@ -3503,12 +3503,6 @@ do-extract:
 			exit 1; \
 		fi; \
 	done
-.if !defined(EXTRACT_PRESERVE_OWNERSHIP)
-	@if [ `${ID} -u` = 0 ]; then \
-		${CHMOD} -R ug-s ${WRKDIR}; \
-		${CHOWN} -R 0:0 ${WRKDIR}; \
-	fi
-.endif
 .endif
 
 # Patch

-- 
We're going for 'working' here. 'clean' is for people with skills...
-- Flemming Jacobsen