From owner-freebsd-usb@FreeBSD.ORG Sat Nov 19 07:40:33 2005 Return-Path: X-Original-To: freebsd-usb@hub.freebsd.org Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33F8A16A41F for ; Sat, 19 Nov 2005 07:40:33 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5359743D45 for ; Sat, 19 Nov 2005 07:40:32 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jAJ7eW9r071258 for ; Sat, 19 Nov 2005 07:40:32 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jAJ7eW6b071257; Sat, 19 Nov 2005 07:40:32 GMT (envelope-from gnats) Resent-Date: Sat, 19 Nov 2005 07:40:32 GMT Resent-Message-Id: <200511190740.jAJ7eW6b071257@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Don L. Belcher" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0F3C16A41F for ; Sat, 19 Nov 2005 07:39:49 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id C804143D45 for ; Sat, 19 Nov 2005 07:39:49 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id jAJ7dn4M073084 for ; Sat, 19 Nov 2005 07:39:49 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id jAJ7dnJe073083; Sat, 19 Nov 2005 07:39:49 GMT (envelope-from nobody) Message-Id: <200511190739.jAJ7dnJe073083@www.freebsd.org> Date: Sat, 19 Nov 2005 07:39:49 GMT From: "Don L. Belcher" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: usb/89269: usb headset does not work with uaudio module X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2005 07:40:33 -0000 >Number: 89269 >Category: usb >Synopsis: usb headset does not work with uaudio module >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Nov 19 07:40:31 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Don L. Belcher >Release: FreeBSD 6 >Organization: SIAD, Inc. >Environment: FreeBSD rover.siad.net 6.0-RC1 FreeBSD 6.0-RC1 #9: Sat Oct 29 06:45:46 PDT 2005 don@rover.siad.net:/usr/obj/usr/home/don/FreeBSD-Version6/src/sys/GENERIC i386 >Description: if usb audio device is at the max or min sample rate an error is returned in this case the max sample rate is 48000 for device. The code checks for max sample < 48000 but should be <= 48000 to work. >How-To-Repeat: >Fix: change sample rate checks to <= src/sys/dev/sound/usb diff uaudio.c uaudio.c.orig 3754,3755c3754,3755 < if (UA_SAMP_LO(a1d) <= ch->sample_rate && < ch->sample_rate <= UA_SAMP_HI(a1d)) { --- > if (UA_SAMP_LO(a1d) < ch->sample_rate && > ch->sample_rate < UA_SAMP_HI(a1d)) { rov >Release-Note: >Audit-Trail: >Unformatted: