Date: Sat, 19 Nov 2005 07:39:49 GMT From: "Don L. Belcher" <don@siad.net> To: freebsd-gnats-submit@FreeBSD.org Subject: usb/89269: usb headset does not work with uaudio module Message-ID: <200511190739.jAJ7dnJe073083@www.freebsd.org> Resent-Message-ID: <200511190740.jAJ7eW6b071257@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 89269
>Category: usb
>Synopsis: usb headset does not work with uaudio module
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-usb
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Nov 19 07:40:31 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Don L. Belcher
>Release: FreeBSD 6
>Organization:
SIAD, Inc.
>Environment:
FreeBSD rover.siad.net 6.0-RC1 FreeBSD 6.0-RC1 #9: Sat Oct 29 06:45:46 PDT 2005 don@rover.siad.net:/usr/obj/usr/home/don/FreeBSD-Version6/src/sys/GENERIC i386
>Description:
if usb audio device is at the max or min sample rate an error is returned
in this case the max sample rate is 48000 for device. The code
checks for max sample < 48000 but should be <= 48000 to work.
>How-To-Repeat:
>Fix:
change sample rate checks to <=
src/sys/dev/sound/usb
diff uaudio.c uaudio.c.orig
3754,3755c3754,3755
< if (UA_SAMP_LO(a1d) <= ch->sample_rate &&
< ch->sample_rate <= UA_SAMP_HI(a1d)) {
---
> if (UA_SAMP_LO(a1d) < ch->sample_rate &&
> ch->sample_rate < UA_SAMP_HI(a1d)) {
rov
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511190739.jAJ7dnJe073083>