From nobody Mon Jul 25 19:51:08 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ls9dm6Lbdz4WbGR; Mon, 25 Jul 2022 19:51:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ls9dm5qmdz3jdf; Mon, 25 Jul 2022 19:51:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658778668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NPt7Dr/mIgjQonauvwqgBkZ4vntf2mmZ7puL5woVtp4=; b=RR5PX8mgBaC7SRgaKVSv+OjvN1g/rgfEZlMmZ5Z1Dl/j7R6KF2xHrSys3oTLuRWQRrxtQX sX+HCbVBgW++AgOQBCtqLlxnG9nbWvX3PRqt0XtuwfEfYmaJy3IK8z+1oG+GjX7La2+etO BuA3RWe3qIbU51uf/vvsjBA6FMCTypOtWUrK9Ftaar1aOhOdTTvWrS/Ng3m8d6TX4Nfs1h BOH2p/4L9OkDtX6uVpI42EFNFBGVS92Oq649fBJWEN1ETH/pfLLDhjy8xu2bMw4f/816wr M3z5YD5W0wWc649eAnASAkArCYFvOGDR5RPF0aiAGU5VicMnFd+lWYYnEme97w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ls9dm4t2Qz18p6; Mon, 25 Jul 2022 19:51:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26PJp8rt003309; Mon, 25 Jul 2022 19:51:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26PJp8CV003308; Mon, 25 Jul 2022 19:51:08 GMT (envelope-from git) Date: Mon, 25 Jul 2022 19:51:08 GMT Message-Id: <202207251951.26PJp8CV003308@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: fb48e998501f - main - Fix unused variable warning in if_pfsync.c List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fb48e998501f8d1defecffb772121a4141cdc2b6 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658778668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NPt7Dr/mIgjQonauvwqgBkZ4vntf2mmZ7puL5woVtp4=; b=HW5tA12sciebjBkxDbcV4rgJzgwXPMtCcplJKaaMbwl4cR+nb1U1hjBjFMkMoZYsRGxomF 2L3DzvQICmOKIuOvZ3bAg5x7pgIWVLTBH20Wzuo4CRIjp+O7aU5Vvz5fnnaiDNq0JUJJDC MS/OSbX8Zhy3WR87yxaSYwzbBbopnpDu2NznPOJdq4Kgfkk+3vzlKLKnUaQNC2yUa7fz4x aUpEe/G4OtMrAvWnrZfqDGg3BvqF4YQYi9qWELDjnYWVP6MQDE5zNHgyjOv5gbotB1TvI8 kiWVcyBQ8Pm1MJp4KGd+5nqbwsnA8w3cyoZ1CfvpJmOclcmaRNFG6BuWyMrOIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658778668; a=rsa-sha256; cv=none; b=vuJYERobzF2AtLNCWlskMjpUhF/lw0X9AK8A1fWhMqrueKPqu6DDb8QV5vyVZvoWEiqUWG Fps59wDHAXXKquZUNkETsDNG4pzOOelby4e/yMAYCxhoPFsOkoXjtVcAvMV0iAT7fx1uVi Z815SzkALFdbR342fAD3L1EjsiNf8tKmPhMs8vj+ef33Wpzprx22JF8XNQ2QvQtEaxO2vt pEP9XRaUvI66xxJGsHpusq5tv1HTo8TdSP5uS7H6lhEB8BCg2ilVqxgJY9TM3Locyr1DcR gZ48RcmuUyhKZWOmQ+8gLWqtF6Oim3of3EsVr066SSs63rvH96NGMZfKX01eLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=fb48e998501f8d1defecffb772121a4141cdc2b6 commit fb48e998501f8d1defecffb772121a4141cdc2b6 Author: Dimitry Andric AuthorDate: 2022-07-25 18:15:51 +0000 Commit: Dimitry Andric CommitDate: 2022-07-25 18:53:48 +0000 Fix unused variable warning in if_pfsync.c With clang 15, the following -Werror warning is produced: sys/netpfil/pf/if_pfsync.c:2153:9: error: variable 'sent' set but not used [-Werror,-Wunused-but-set-variable] int i, sent = 0; ^ The 'sent' variable was used in the for loop later in the pfsync_bulk_update() function, but refactoring in 4fc65bcbe3fb7 got rid of it. Remove the variable since it no longer serves any purpose. MFC after: 3 days --- sys/netpfil/pf/if_pfsync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 8edc5564b9a7..5f082576a3f9 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2150,7 +2150,7 @@ pfsync_bulk_update(void *arg) { struct pfsync_softc *sc = arg; struct pf_kstate *s; - int i, sent = 0; + int i; PFSYNC_BLOCK_ASSERT(sc); CURVNET_SET(sc->sc_ifp->if_vnet); @@ -2191,7 +2191,6 @@ pfsync_bulk_update(void *arg) pfsync_bulk_update, sc); goto full; } - sent++; } } PF_HASHROW_UNLOCK(ih);