From nobody Tue Dec 14 21:53:49 2021 X-Original-To: freebsd-numerics@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 688AC18EBD83 for ; Tue, 14 Dec 2021 21:53:51 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDBwG6jJDz3vqS; Tue, 14 Dec 2021 21:53:50 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 8513F6DEA; Tue, 14 Dec 2021 21:53:50 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 34A7B44BCF; Tue, 14 Dec 2021 22:53:49 +0100 (CET) Content-Type: text/plain; charset=us-ascii List-Id: Discussions of high quality implementation of libm functions List-Archive: https://lists.freebsd.org/archives/freebsd-numerics List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-numerics@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: s_sincosl.c: remove unused variable From: Dimitry Andric In-Reply-To: <20211214200552.GA49922@troutmask.apl.washington.edu> Date: Tue, 14 Dec 2021 22:53:49 +0100 Cc: Steve Kargl , Michal Meloun Content-Transfer-Encoding: quoted-printable Message-Id: References: <20211214200552.GA49922@troutmask.apl.washington.edu> To: enh via freebsd-numerics X-Mailer: Apple Mail (2.3693.40.0.1.81) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639518831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wn5NZg+vqg4fIXX+SxcOLadSzhZN8k1NvZfHgLWZQM0=; b=wqSB1/dFobEC0eFG7je0VgyR21k45Hi2OkRm8qGkL8CNqz6fTWO3N4rG2xndCLytF6/pTg TEUmsaoMGDs4hZRFmPinndX2948wkqg/VuOSK/y1nnm2ZlVYiqDEmO6vjlAr+7sH+0vKul iE15H8kAYx3sXAbnurFxebbH/vQn5Je0ZKzmxsNfOAz3d/itXNrUDUj9soXiClPVm7t5Mh lajTK9wqeyJBMfWO+3r/YX0Cj8TC79l3qCfhjVjFxiBlOB+QV4nBM4IntBoH/c/LjuGrVe kcdRcmEkWAn8gkVxZ5azrN4/PAbde6iddhUU7B1oNTmm6ePy9pSOR7YQkVghnA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639518831; a=rsa-sha256; cv=none; b=dHT3VdtoB7zlWcA18xpiBhAn0dDYjrI57ZZfGoRv0/Tc2IzlxQk3nDDpriZMpHERzAI89C RgQoope9HwA0pTQ2WdmDAcObLWnMDA1vlU8/K2Vsu/NDqdrJtUpzrKL/sFEf6ItlhCaLCk zluXOkkCH/6vBgi4QDBxiCEDYRXKxjdPXCLwZ5OZAsz8NYyxPlCkpHhcsnvR/JGWq7e99Q CfMWc1f3COoxX36cjyXUxB+c93gS+4C61FBQQLYnpr0rNS72zYEOXXB7l092vo+8uBE6Sd fJkBSKhCvMYnn3jQsuuBZdYiGm3KdsAaExHws4S2KG5LdMP/ZZ1OX8GzJpJncA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 14 Dec 2021, at 21:05, Steve Kargl = wrote: >=20 > On Tue, Dec 14, 2021 at 11:06:53AM -0800, enh via freebsd-numerics = wrote: >> Newer versions of clang complain about this, and it seems genuinely = unneeded. >>=20 >> It was in the original commit, and judging from that I think it's = just >> a copy & paste leftover from inlinine sinl() and cosl() --- the < >> M_PI_4 case in sinl() needs the original sign. >=20 > Yep. sgn is unneeded. Sorry about that. Thanks, committed in: = https://cgit.freebsd.org/src/commit/?id=3D20d425842a4f80f9efc1de3f7a3b0434= 35fe4b39 -Dimitry