Date: Tue, 24 Feb 2009 00:54:46 GMT From: Anonymous <swell.k@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/132035: [patch] graphics/libdrm: allow slave ports use their own COMMENT Message-ID: <200902240054.n1O0sk4R041189@www.freebsd.org> Resent-Message-ID: <200902240100.n1O10A42094977@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 132035
>Category: ports
>Synopsis: [patch] graphics/libdrm: allow slave ports use their own COMMENT
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Feb 24 01:00:10 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
FreeBSD luffy 8.0-CURRENT FreeBSD 8.0-CURRENT #0 r188760M: Wed Feb 18 20:33:53 UTC 2009 root@luffy:/usr/obj/usr/src/sys/PHOENIX amd64
>Description:
For the upcoming slave port libdrm-nouveau I need to set COMMENT for it. Because libdrm uses `=' instead of `?=' including ${MASTERDIR}/Makefile at the end of the slave port's Makefile inherits libdrm's COMMENT value and discards the one in libdrm-nouveau.
>How-To-Repeat:
>Fix:
Replace `=' with `?=' for COMMENT in graphics/libdrm/Makefile
Patch attached with submission follows:
Index: graphics/libdrm/Makefile
===================================================================
RCS file: /home/csup/ports/graphics/libdrm/Makefile,v
retrieving revision 1.12
diff -u -p -r1.12 Makefile
--- graphics/libdrm/Makefile 24 Jan 2009 17:23:47 -0000 1.12
+++ graphics/libdrm/Makefile 22 Feb 2009 05:29:57 -0000
@@ -11,7 +11,7 @@ CATEGORIES= graphics x11
MASTER_SITES= http://dri.freedesktop.org/libdrm/
MAINTAINER= x11@FreeBSD.org
-COMMENT= Userspace interface to kernel Direct Rendering Module services
+COMMENT?= Userspace interface to kernel Direct Rendering Module services
BUILD_DEPENDS+= ${LOCALBASE}/libdata/pkgconfig/pthread-stubs.pc:${PORTSDIR}/devel/libpthread-stubs
RUN_DEPENDS+= ${LOCALBASE}/libdata/pkgconfig/pthread-stubs.pc:${PORTSDIR}/devel/libpthread-stubs
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902240054.n1O0sk4R041189>