From owner-svn-src-head@freebsd.org Fri Nov 13 19:55:24 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64BA62EC580; Fri, 13 Nov 2020 19:55:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CXq2N2L4Dz4qWb; Fri, 13 Nov 2020 19:55:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 3D5213D1B; Fri, 13 Nov 2020 19:55:24 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f172.google.com with SMTP id 3so7587225qtx.3; Fri, 13 Nov 2020 11:55:24 -0800 (PST) X-Gm-Message-State: AOAM533BnviqK/Ub+IMatZRPwmzX7KP/nP/NilOtaFjXPA1mnWCWt4ow au40mpf/vWwmhYX2wLsNHjGiFIcbIAmPR/7VWT4= X-Google-Smtp-Source: ABdhPJwq2JGaCiUBLCVIyybWevIULGNLJSALwe6MLPb11Z33OIFUIDhS3RNHlYWGTtUID5e7vK0ZMUYJSvhNvttD0D4= X-Received: by 2002:ac8:4e87:: with SMTP id 7mr3416242qtp.310.1605297323419; Fri, 13 Nov 2020 11:55:23 -0800 (PST) MIME-Version: 1.0 References: <202011131850.0ADIoOIe026490@repo.freebsd.org> In-Reply-To: <202011131850.0ADIoOIe026490@repo.freebsd.org> From: Kyle Evans Date: Fri, 13 Nov 2020 13:55:09 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r367647 - head/tests/sys/vm To: Adrian Chadd Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 19:55:24 -0000 On Fri, Nov 13, 2020 at 12:50 PM Adrian Chadd wrote: > > Author: adrian > Date: Fri Nov 13 18:50:24 2020 > New Revision: 367647 > URL: https://svnweb.freebsd.org/changeset/base/367647 > > Log: > [tests] Fix unused variable warning in gcc > > Reviewed by: markj, imp, cem, > Approved by: markj > Differential Revision: https://reviews.freebsd.org/D26792 > > Modified: > head/tests/sys/vm/page_fault_signal.c > > Modified: head/tests/sys/vm/page_fault_signal.c > ============================================================================== > --- head/tests/sys/vm/page_fault_signal.c Fri Nov 13 18:34:13 2020 (r367646) > +++ head/tests/sys/vm/page_fault_signal.c Fri Nov 13 18:50:24 2020 (r367647) > @@ -115,7 +114,7 @@ ATF_TC_BODY(page_fault_signal__segv_accerr_2, tc) > ATF_REQUIRE(p != MAP_FAILED); > if (sigsetjmp(sig_env, 1) == 0) { > setup_signals(); > - dummy = *p; > + (void)*(volatile int *)p; > } > (void)munmap(p, sz); > ATF_CHECK_EQ(SIGSEGV, last_sig); A minor nit, we could/should probably add an explicit atf_tc_fail() after the access. While it seems unlikely that the compiler might elide it and it would still fail anyways because last_sig would certainly not be SIGSEGV, it'd be good to catch it earlier with an explicit fail. I don't recall how good atf-c's diagnostics are otherwise, if it'd be clear that last_sig == 0 or not without requiring further triage. Thanks, Kyle Evans